Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox, Menu, Switch] Audit focus states on disabled components #734

Merged
merged 7 commits into from
Oct 28, 2024
Merged

[Checkbox, Menu, Switch] Audit focus states on disabled components #734

merged 7 commits into from
Oct 28, 2024

Commits on Oct 13, 2024

  1. Partial changes for issue mui#656 

    - Removed focusableWhenDisabled from Menu trigger
- Passed down disabled prop to the component renderer to enable the disabled state to the DOM element
    @hakim-toptal
    hakim-toptal committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dd6b148 View commit details
    Browse the repository at this point in the history

  2. Revert "Partial changes for issue mui#656" 

    This reverts commit dd6b148.
    @onehanddev
    onehanddev committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    cc20541 View commit details
    Browse the repository at this point in the history

  3. Reapply "Partial changes for issue mui#656" 

    This reverts commit cc20541.
    @onehanddev
    onehanddev committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    55f8f07 View commit details
    Browse the repository at this point in the history

  4. lint fixes

    @onehanddev
    onehanddev committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e5461c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Refactor: Set 'disabled' via useCheckboxRoot's getButtonProps and rem… 

    …ove 'aria-disabled'. Applied the same update to Switch component.
    @onehanddev
    onehanddev committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    de53105 View commit details
    Browse the repository at this point in the history

  2. Added comma as before while reverting changes in CheckboxRoot

    @onehanddev
    onehanddev committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8ce05b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Updated unit tests to expect disabled attribute instead of aria-disab… 

    …led for Switch and Checkbox components.
    @onehanddev
    onehanddev committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    238a110 View commit details
    Browse the repository at this point in the history