[ToggleButton][ToggleButtonGroup] Create ToggleButton and ToggleButtonGroup
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
new feature
Netlify deploy preview |
mj12albert
force-pushed
the
feat/toggle-button
branch
4 times, most recently
from
6c0fe92
to
6e04229
Compare
mj12albert
commented
Oct 29, 2024
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
feat/toggle-button
branch
from
e07b2ef
to
f23c6df
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
feat/toggle-button
branch
5 times, most recently
from
9bcba83
to
3a74374
Compare
mj12albert
changed the title
ToggleButtonToggleButton and ToggleButtonGroup
mj12albert
force-pushed
the
feat/toggle-button
branch
2 times, most recently
from
7cc24fd
to
b06a97d
Compare
mj12albert
added
the
component: button group
mj12albert
force-pushed
the
feat/toggle-button
branch
10 times, most recently
from
bcdd1cc
to
7c449d8
Compare
mj12albert
force-pushed
the
feat/toggle-button
branch
4 times, most recently
from
5d873bf
to
e4f7794
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
mj12albert
force-pushed
the
feat/toggle-button
branch
3 times, most recently
from
03bcd17
to
dd0c57d
Compare
atomiks
reviewed
Nov 11, 2024
| @@ -25,6 +25,7 @@ const CompositeRoot = React.forwardRef(function CompositeRoot( | |||
| itemSizes, | |||
| loop, | |||
| cols, | |||
| isRtl, | |||
There was a problem hiding this comment.
rtl without is is fine; we match HTML naming without is indicators
atomiks
reviewed
Nov 11, 2024
| function App() { | ||
| const [activeIndex, setActiveIndex] = React.useState(0); | ||
| return ( | ||
| <CompositeRoot activeIndex={activeIndex} onActiveIndexChange={setActiveIndex}> |
There was a problem hiding this comment.
Composite sets data-active internally, but we use data-highlighted for our components. We could remove the data-active attr internally in Composite and use the highlighted: boolean ownerState instead to apply data-highlighted
There was a problem hiding this comment.
Yeah, the active part of its ownerState should be removed, or changed to highlighted
mj12albert
force-pushed
the
feat/toggle-button
branch
from
fe8bc95
to
846fde7
Compare
mj12albert
force-pushed
the
feat/toggle-button
branch
from
846fde7
to
724af6d
Compare
1 task
atomiks
approved these changes
Nov 14, 2024
atomiks
reviewed
Nov 14, 2024
Comment on lines
+109
to
+115
| ## RTL | ||
|
|
||
| Use the `direction` prop to configure a RTL toggle button group: | ||
|
|
||
| ```tsx | ||
| <ToggleButtonGroup.Root direction="rtl">{/* toggle buttons */}</ToggleButtonGroup.Root> | ||
| ``` |
There was a problem hiding this comment.
Should this match the native dir prop instead?
mj12albert
force-pushed
the
feat/toggle-button
branch
from
724af6d
to
8702100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Closes #31
Docs: