[examples] Switch Next.js examples to ESM, remove unnecessary type #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karl Horky <[email protected]>
Signed-off-by: Karl Horky <[email protected]>
karlhorky
changed the title
|
Cool. I guess we should update https://github.com/mui/pigment-css/blob/master/examples/pigment-css-nextjs-ts/ too? |
|
karlhorky
commented
Jun 8, 2024
Comment on lines
-3
to
+10
| "target": "es5", | ||
| "lib": ["dom", "dom.iterable", "esnext"], | ||
| "allowJs": true, | ||
| "skipLibCheck": true, | ||
| "strict": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "noEmit": true, | ||
| "esModuleInterop": true, | ||
| "module": "esnext", | ||
| "moduleResolution": "node", | ||
| "moduleResolution": "bundler", |
karlhorky
commented
Jun 8, 2024
Comment on lines
+1
to
+3
| { | ||
| "extends": "next/core-web-vitals" | ||
| } |
There was a problem hiding this comment.
default ESLint config with create-next-app
karlhorky
commented
Jun 8, 2024
Comment on lines
-24
to
+22
| "@/*": ["./src/*"] | ||
| "@/*": ["./*"] |
oliviertassinari
changed the title
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @oliviertassinari and others, first of all, thanks for Pigment CSS! I will recommend this to our students at @upleveled :)
Quick PR to fix the Next.js "manual installation" example:
next.config.mjsis now ESM by default since a whilecreate-next-app