Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't notify cache about nonces; pass the account nonce provider, instead #6603

Draft
wants to merge 17 commits into
base: selection-by-ppu
Choose a base branch
from

Conversation

andreibancioiu
Copy link
Collaborator

@andreibancioiu andreibancioiu commented Nov 13, 2024

Reasoning behind the pull request

  • This is an improvement upon Mempool: improve selection algorithm #6581.
  • In certain exotic cases, concurrent notifications about account nonces might have lead the mempool to hold stale account nonces (very minor issue, but still an issue).
  • The flow of forgetting all account nonces after reverting a block is suboptimal (and somehow over-engineered).

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@andreibancioiu andreibancioiu changed the title Don't notify cache about nonces; provide the account nonce provider, instead Don't notify cache about nonces; pass the account nonce provider, instead Nov 13, 2024
@andreibancioiu andreibancioiu self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants