FIX(client): Prevent local muted users from triggering attenuation

[jlallas384]

When 'while others users talk' attenuation is enabled, unmuted users still trigger attenuation even if they are locally muted.

The fix is don't add local muted users' audio source to the mixing for the audio output

Fixes #6247

Checks

• My commits follow the commit guidelines

[Krzmbrzl]

Note that this also changes the behavior in that audio samples for cases where user == nullptr are discarded whereas before they were still added to qlMix.
That's probably okay though 👀

[Hartmnt]

Note that this also changes the behavior in that audio samples for cases where user == nullptr are discarded whereas before they were still added to qlMix. That's probably okay though 👀

This could be a problem for sound file samples... I would have first to look at the code again to confirm though

[Krzmbrzl]

Oh indeed - totally missed that!

[Hartmnt]

This change does indeed prevent any sound files (audio cues and notification sounds) from playing.

You have to make sure that samples without a valid user pointer are also added to qlMix

[Hartmnt]

This almost works, but not quite.

Audio samples are now played correctly, and application attenuation is handled gracefully.
However, local muting a priority speaker has no effect now. Which means other users are still locally attenuated, if a locally muted PS speaks.

I think it should be enough to move the !localMute condition to the last else

[Hartmnt]

@jlallas384 Do you still have the time and motivation to finish this?