Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS(dev): Clean up network protocol docs #6714

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

Kissaki
Copy link
Member

@Kissaki Kissaki commented Jan 26, 2025

  • Replace non-breaking space ("nbsp") characters with normal space characters
  • Fix rst cross-document reference that worked on readthedocs but does not work on GitHub rendering

These changes can be considered a follow-up or fixup to PR #6623, which integrated the network protocol docs into this repository.

Checks

The cross-document reference apparently worked on readthedocs (our previous docs), but does not work on GitHub.

The cross-document figure reference is replaced with a file reference.
The figure follows below the paragraph.
@Kissaki Kissaki merged commit 9d512e6 into mumble-voip:master Jan 27, 2025
15 checks passed
@Kissaki Kissaki deleted the docs/netwprot branch January 27, 2025 16:57
Kissaki added a commit that referenced this pull request Jan 27, 2025
Convert our network protocol docs from rst (ReStructuredText) to md (Markdown) format.

---

This changeset is a followup to PR #6623. In that PR, which first integrated these docs into this repository, the comments indicated consensus that the docs should be in Markdown format to match our other docs.

This changeset is based on PR #6714, which does some baseline corrections, and which should be merged first.

---

Two tables are not converted to Markdown tables because they are not flat tables, which is hard, if not impossible, to represent in Markdown. Preformatted code blocks are being used for them instead.

Otherwise, the conversion seems straightforward.

The changeset includes individual commits by change type, so each kind of change can be traced. The first commit is purely a rename to ensure Git follows the content history across the file conversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants