-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unary operators #136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 83.39% 83.59% +0.20%
==========================================
Files 158 158
Lines 10646 10713 +67
==========================================
+ Hits 8878 8956 +78
+ Misses 1768 1757 -11
Continue to review full report at Codecov.
|
Seems to be because this is left unimplemented: mun/crates/mun_hir/src/ty/infer.rs Line 403 in 39babc4
|
Looks like CI failed due to a network error. |
It looks like not is actually implemented for integers in Rust, so I'll go ahead and add that. |
I checked master, but the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I approved it!
However, there appears to be a merge conflict. Can you rebase this branch on master?
Sorry about this, but I (still) don't know how to rebase. Can you give me some steps on doing that? |
Sure, does this help: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request Squashing your changes is not necessary. |
I think I've gotten codegen done, but it seems that the type of expressions with unary operators is, for whatever reason, unknown.