Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime_capi): add garbage collection methods #163

Merged
merged 2 commits into from
May 8, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented May 6, 2020

Adds functions necessary for making a full-fledged C++ wrapper around the runtime.

This should contain the last changes to the runtime CAPI before the Mun v0.2 release 🤞

failure::Error is already a boxed type, so there is no need to wrap it
in a Box
@Wodann Wodann requested a review from baszalmstra May 6, 2020 19:27
@Wodann Wodann self-assigned this May 6, 2020
@Wodann Wodann changed the title feat: interop C feat(runtime_capi): add garbage collection methods May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #163 into master will increase coverage by 0.14%.
The diff coverage is 99.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   82.71%   82.85%   +0.14%     
==========================================
  Files         162      163       +1     
  Lines       11130    11221      +91     
==========================================
+ Hits         9206     9297      +91     
  Misses       1924     1924              
Impacted Files Coverage Δ
crates/mun_runtime_capi/src/hub.rs 80.95% <ø> (ø)
crates/mun_runtime_capi/src/lib.rs 96.77% <95.23%> (-0.20%) ⬇️
crates/mun_runtime/src/lib.rs 71.87% <100.00%> (ø)
crates/mun_runtime/src/struct_ref.rs 76.80% <100.00%> (ø)
crates/mun_runtime_capi/src/gc.rs 100.00% <100.00%> (ø)
crates/mun_runtime_capi/src/tests.rs 99.47% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf1dc7...67e6dec. Read the comment docs.

@Wodann Wodann force-pushed the feature/interop-c branch from b1979aa to 1be8ef0 Compare May 7, 2020 08:41
@Wodann Wodann force-pushed the feature/interop-c branch from 1be8ef0 to 67e6dec Compare May 8, 2020 08:55
@Wodann Wodann merged commit 27711a9 into mun-lang:master May 8, 2020
@Wodann Wodann deleted the feature/interop-c branch May 8, 2020 09:19
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants