Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adds function prototype #166

Merged

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented May 8, 2020

Adds the following concepts:

  • Function signature: just the type signature of a function
  • Function prototype: a type signature and a name but not an implementation
  • Function definition: a prototype and an implementation

Coupled to: mun-lang/abi-c#7 and mun-lang/runtime-ffi#6

@baszalmstra baszalmstra requested a review from Wodann May 8, 2020 10:24
@baszalmstra baszalmstra self-assigned this May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #166 into master will decrease coverage by 0.13%.
The diff coverage is 79.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   82.90%   82.77%   -0.14%     
==========================================
  Files         163      163              
  Lines       11226    11239      +13     
==========================================
- Hits         9307     9303       -4     
- Misses       1919     1936      +17     
Impacted Files Coverage Δ
crates/mun/src/main.rs 0.00% <0.00%> (ø)
crates/mun_abi/src/lib.rs 92.85% <ø> (ø)
crates/mun_runtime/tests/memory.rs 100.00% <ø> (ø)
crates/tools/src/abi.rs 91.66% <ø> (-4.17%) ⬇️
crates/mun_runtime/src/assembly.rs 62.76% <35.29%> (-2.07%) ⬇️
crates/mun_abi/src/autogen.rs 64.44% <75.00%> (-0.18%) ⬇️
crates/mun_abi/src/autogen_impl.rs 93.01% <82.89%> (-2.39%) ⬇️
crates/mun_runtime/src/lib.rs 72.04% <87.50%> (+0.16%) ⬆️
crates/mun_abi/src/function_info.rs 100.00% <100.00%> (ø)
crates/mun_codegen/src/code_gen/symbols.rs 94.07% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff08f1c...cfc210e. Read the comment docs.

@baszalmstra baszalmstra force-pushed the feature/function_prototype branch 3 times, most recently from b5e496a to cfc210e Compare May 8, 2020 10:47
@baszalmstra baszalmstra merged commit 0d6e36d into mun-lang:master May 8, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
@Wodann Wodann changed the title misc: adds function prototype refactor: adds function prototype May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants