-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: initial LSP support #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! Happy to see the Mun language server coming together 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating some of the fixes. It'd be good to merge this sooner rather than later, but there are still several outstanding questions.
The commit history is also a bit of a mess, which is fine during the review process but not once we merge. More details are outlined in our contributing guidelines.
Co-authored-by: Wodann <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 81.10% 78.94% -2.16%
==========================================
Files 189 196 +7
Lines 12325 12608 +283
==========================================
- Hits 9996 9954 -42
- Misses 2329 2654 +325
Continue to review full report at Codecov.
|
2276b72
to
e7eb7ec
Compare
This MR adds support for the initial LSP scaffolding and can be started from the mun main executable using:
Note that currently only diagnostics are supported, but it is a nice starting point for future developments. The README now contains instructions on how to use this in either
vscode
orvim
.