Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: initial LSP support #236

Merged
merged 7 commits into from
Jul 17, 2020

Conversation

tdejager
Copy link
Collaborator

This MR adds support for the initial LSP scaffolding and can be started from the mun main executable using:

mun language-server

Note that currently only diagnostics are supported, but it is a nice starting point for future developments. The README now contains instructions on how to use this in either vscode or vim.

@tdejager tdejager requested a review from Wodann June 27, 2020 13:02
@Wodann Wodann added this to the Mun v0.3.0 milestone Jun 29, 2020
Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! Happy to see the Mun language server coming together 👏

@baszalmstra baszalmstra changed the title Intial LSP support feature: initial LSP support Jul 4, 2020
Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating some of the fixes. It'd be good to merge this sooner rather than later, but there are still several outstanding questions.

The commit history is also a bit of a mess, which is fine during the review process but not once we merge. More details are outlined in our contributing guidelines.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #236 into master will decrease coverage by 2.15%.
The diff coverage is 23.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   81.10%   78.94%   -2.16%     
==========================================
  Files         189      196       +7     
  Lines       12325    12608     +283     
==========================================
- Hits         9996     9954      -42     
- Misses       2329     2654     +325     
Impacted Files Coverage Δ
crates/mun_compiler/src/driver/display_color.rs 71.42% <ø> (ø)
crates/mun_compiler_daemon/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_hir/src/db.rs 100.00% <ø> (ø)
crates/mun_language_server/src/cancelation.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/capabilities.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/conversion.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/diagnostics.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/protocol/message.rs 18.82% <ø> (ø)
crates/mun_syntax/src/lib.rs 69.56% <ø> (-2.18%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a091b...5a98295. Read the comment docs.

@baszalmstra baszalmstra force-pushed the feature/lsp/filesystem branch 2 times, most recently from 2276b72 to e7eb7ec Compare July 17, 2020 13:09
@baszalmstra baszalmstra merged commit 98979ca into mun-lang:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants