feat(lsp): support for completions #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 80.86% 80.80% -0.07%
==========================================
Files 245 258 +13
Lines 14937 15480 +543
==========================================
+ Hits 12079 12508 +429
- Misses 2858 2972 +114
Continue to review full report at Codecov.
|
baszalmstra
force-pushed
the
feature/completion
branch
from
7231701 to
613064a
Compare
baszalmstra
force-pushed
the
feature/completion
branch
2 times, most recently
from
2f7cbb0 to
90f1a79
Compare
Wodann
requested changes
Mar 28, 2021
| // context. The actual original_file will be used for completion. | ||
| let file_with_fake_ident = { | ||
| let parse = db.parse(position.file_id); | ||
| let edit = Indel::insert(position.offset, String::from("intellijRulezz")); |
There was a problem hiding this comment.
"intellijRulezz" is a standard string used for this purpose
Wodann
reviewed
Apr 10, 2021
Wodann
changed the title
baszalmstra
force-pushed
the
feature/completion
branch
2 times, most recently
from
8993d02 to
b1f50b2
Compare
baszalmstra
force-pushed
the
feature/completion
branch
from
b1f50b2 to
012fa9e
Compare
Wodann
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for completions for IDEs. This is far from finished, there is a lot more to add but I didn't want to make this too big. Currently supports two types of completion:
I used the same design as Rust Analyzer.
This PR depends on #298