-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(scripts): script to run and collect Miri logs #537
Merged
baszalmstra
merged 5 commits into
mun-lang:main
from
belagoesr:improvement/miri-log-script
Dec 19, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
48cbdb9
chore: add script to collect miri logs
182a595
chore: add install line in script
0a10c99
Merge branch 'main' into improvement/miri-log-script
belagoesr 4ae38f1
Merge remote-tracking branch 'origin/main' into improvement/miri-log-…
Wodann 5bf6d75
misc: apply review suggestions
Wodann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#!/bin/bash | ||
|
||
# This script collect logs for running Miri in each crate | ||
|
||
# Install nightly Miri | ||
rustup toolchain install nightly --profile minimal --component miri | ||
|
||
# Create the folder for logs | ||
mkdir -p .logs | ||
|
||
# Run clean to ensure that we get all miri errors | ||
cargo clean | ||
|
||
for path in crates/* ; do | ||
echo "Running miri in '$path'" | ||
package=$(basename "$path") | ||
OUTPUT_FILE=.logs/log_$package | ||
MIRIFLAGS="\ | ||
-Zmiri-disable-stacked-borrows \ | ||
-Zmiri-backtrace=full \ | ||
-Zmiri-disable-isolation" \ | ||
# Log to stdout and a file - for future reference | ||
cargo +nightly miri test --package $package --no-fail-fast 2>&1 | tee $OUTPUT_FILE | ||
done |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@belagoesr do you happen to remember why
cargo clean
is necessary?I'm assuming that it's to ensure that the generated logs always contain all errors/warnings.