Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to check if compiler output strings is valid utf8 #67

Merged
merged 1 commit into from
Jan 3, 2020
Merged

test: add test to check if compiler output strings is valid utf8 #67

merged 1 commit into from
Jan 3, 2020

Conversation

legendiguess
Copy link
Contributor

closes #52

@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #67 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   72.09%   72.14%   +0.04%     
==========================================
  Files         109      109              
  Lines        7279     7291      +12     
==========================================
+ Hits         5248     5260      +12     
  Misses       2031     2031
Impacted Files Coverage Δ
crates/mun_runtime/src/test.rs 96.35% <100%> (+0.35%) ⬆️
crates/mun_target/src/spec/windows_msvc_base.rs 100% <0%> (ø) ⬆️
...ates/mun_target/src/spec/x86_64_pc_windows_msvc.rs 100% <0%> (ø) ⬆️
crates/mun_codegen/src/code_gen/linker.rs 35.63% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6896708...9cec921. Read the comment docs.

@legendiguess legendiguess marked this pull request as ready for review December 23, 2019 06:46
Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the pull request. This is precisely the set-up that we were looking for :)

Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Now the unit test is much more minimalistic :)

There is still one typo left. Can you fix that? Once that's done, I'll merge both of your pull requests 👍

@Wodann Wodann merged commit 6be21e3 into mun-lang:master Jan 3, 2020
@baszalmstra
Copy link
Collaborator

@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test whether mun_compiler generated strings are valid UTF-8
4 participants