-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test to check if compiler output strings is valid utf8 #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 72.09% 72.14% +0.04%
==========================================
Files 109 109
Lines 7279 7291 +12
==========================================
+ Hits 5248 5260 +12
Misses 2031 2031
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on the pull request. This is precisely the set-up that we were looking for :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Now the unit test is much more minimalistic :)
There is still one typo left. Can you fix that? Once that's done, I'll merge both of your pull requests 👍
closes #52