refactor: dynamically include struct information in type information #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=========================================
+ Coverage 74.42% 74.8% +0.38%
=========================================
Files 121 121
Lines 9521 9599 +78
=========================================
+ Hits 7086 7181 +95
+ Misses 2435 2418 -17
Continue to review full report at Codecov.
|
baszalmstra
approved these changes
Jan 22, 2020
Wodann
force-pushed
the
refactor/struct-type-info
branch
2 times, most recently
from
315bd39 to
91e64f2
Compare
baszalmstra
approved these changes
Jan 29, 2020
Wodann
force-pushed
the
refactor/struct-type-info
branch
from
91e64f2 to
37f9f36
Compare
…mation to be appended Unique MunTypeInfo structs are globally allocated only once, but can be referred to in multiple places. Depending on the TypeGroup, additional information can be appended in memory. For StructTypes, a StructInfo struct is appended.
Wodann
force-pushed
the
refactor/struct-type-info
branch
from
37f9f36 to
7407966
Compare
Wodann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #83.
TypeInfois now a globally allocated type that can potentially have additional information appended, depending on itsTypeGroup. As a result, all places that passedMunTypeInfoby value now use aMunTypeInfo*This is not reflected in the
mun_abi.h, as including auniontype would affect the size of allMunTypeInfo- not just the ones that have aStructInfoappended. Please come up with more guarantees or tests, that could make this more secure.