Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a bunch of primitive types. #95

Closed
wants to merge 3 commits into from

Conversation

baszalmstra
Copy link
Collaborator

Adds primitive types: i8, i16, i32, i64, isize, int, u8, u16, u32, u64, usize, uint, f32, f64, float.

There is no conversion between them. This should be implemented in a separate PR.

@baszalmstra baszalmstra requested a review from Wodann March 6, 2020 14:39
@baszalmstra baszalmstra self-assigned this Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #95 into master will decrease coverage by 0.71%.
The diff coverage is 44.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   76.82%   76.11%   -0.72%     
==========================================
  Files         122      124       +2     
  Lines        9601     9795     +194     
==========================================
+ Hits         7376     7455      +79     
- Misses       2225     2340     +115     
Impacted Files Coverage Δ
crates/mun_hir/src/ty/infer/coerce.rs 100.00% <0.00%> (ø)
crates/mun_hir/src/builtin_type.rs 19.29% <0.00%> (ø)
crates/mun_hir/src/ty/primitives.rs 39.81% <0.00%> (ø)
crates/mun_hir/src/code_model.rs 75.91% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce4626...c7ed4ff. Read the comment docs.

@Wodann
Copy link
Collaborator

Wodann commented Mar 7, 2020

@baszalmstra
Copy link
Collaborator Author

Closing this in favor of #96

@baszalmstra baszalmstra closed this Mar 7, 2020
@Wodann Wodann modified the milestones: Mun v0.2, Mun v0.2.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants