chore: update @mysticatea/eslint-plugin to latest

mysticatea · Nov 30, 2021 · 46d18f0 · 46d18f0
1 parent f45c614
commit 46d18f0
Show file tree

Hide file tree

Showing 40 changed files with 116 additions and 118 deletions.
diff --git a/lib/rules/callback-return.js b/lib/rules/callback-return.js
@@ -6,24 +6,24 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "require `return` statements after callbacks",
             category: "Stylistic Issues",
             recommended: false,
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/callback-return.md",
         },
+        fixable: null,
+        messages: {
+            missingReturn: "Expected return with your callback function.",
+        },
         schema: [
             {
                 type: "array",
                 items: { type: "string" },
             },
         ],
-        fixable: null,
-        messages: {
-            missingReturn: "Expected return with your callback function.",
-        },
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/exports-style.js b/lib/rules/exports-style.js
@@ -148,7 +148,6 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/exports-style.md",
         },
-        type: "suggestion",
         fixable: null,
         schema: [
             {
@@ -161,6 +160,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/global-require.js b/lib/rules/global-require.js
@@ -49,7 +49,6 @@ function isShadowed(scope, node) {
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description:
                 "require `require()` calls to be placed at top-level module scope",
@@ -59,10 +58,11 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/global-require.md",
         },
         fixable: null,
-        schema: [],
         messages: {
             unexpected: "Unexpected require().",
         },
+        schema: [],
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/handle-callback-err.js b/lib/rules/handle-callback-err.js
@@ -6,7 +6,6 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "require error handling in callbacks",
             category: "Possible Errors",
@@ -15,14 +14,15 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/handle-callback-err.md",
         },
         fixable: null,
+        messages: {
+            expected: "Expected error to be handled.",
+        },
         schema: [
             {
                 type: "string",
             },
         ],
-        messages: {
-            expected: "Expected error to be handled.",
-        },
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/no-callback-literal.js b/lib/rules/no-callback-literal.js
@@ -14,9 +14,9 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-callback-literal.md",
         },
-        type: "problem",
         fixable: null,
         schema: [],
+        type: "problem",
     },
 
     create(context) {

diff --git a/lib/rules/no-deprecated-api.js b/lib/rules/no-deprecated-api.js
@@ -659,8 +659,8 @@ function toName(type, path) {
     return type === ReferenceTracker.CALL
         ? `${baseName}()`
         : type === ReferenceTracker.CONSTRUCT
-            ? `new ${baseName}()`
-            : baseName
+        ? `new ${baseName}()`
+        : baseName
 }
 
 /**
@@ -688,7 +688,6 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-deprecated-api.md",
         },
-        type: "problem",
         fixable: null,
         schema: [
             {
@@ -720,6 +719,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        type: "problem",
     },
     create(context) {
         const {

diff --git a/lib/rules/no-extraneous-import.js b/lib/rules/no-extraneous-import.js
@@ -21,7 +21,6 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-extraneous-import.md",
         },
-        type: "problem",
         fixable: null,
         schema: [
             {
@@ -35,6 +34,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        type: "problem",
     },
     create(context) {
         const filePath = context.getFilename()

diff --git a/lib/rules/no-extraneous-require.js b/lib/rules/no-extraneous-require.js
@@ -21,7 +21,6 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-extraneous-require.md",
         },
-        type: "problem",
         fixable: null,
         schema: [
             {
@@ -35,6 +34,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        type: "problem",
     },
     create(context) {
         const filePath = context.getFilename()

diff --git a/lib/rules/no-hide-core-modules.js b/lib/rules/no-hide-core-modules.js
@@ -50,6 +50,7 @@ const BACK_SLASH = /\\/gu
 
 module.exports = {
     meta: {
+        deprecated: true,
         docs: {
             description:
                 "disallow third-party modules which are hiding core modules",
@@ -58,8 +59,6 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-hide-core-modules.md",
         },
-        type: "problem",
-        deprecated: true,
         fixable: null,
         schema: [
             {
@@ -77,6 +76,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        type: "problem",
     },
     create(context) {
         if (context.getFilename() === "<input>") {

diff --git a/lib/rules/no-missing-import.js b/lib/rules/no-missing-import.js
@@ -20,7 +20,6 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-missing-import.md",
         },
-        type: "problem",
         fixable: null,
         schema: [
             {
@@ -33,6 +32,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        type: "problem",
     },
     create(context) {
         const filePath = context.getFilename()

diff --git a/lib/rules/no-missing-require.js b/lib/rules/no-missing-require.js
@@ -20,7 +20,6 @@ module.exports = {
             url:
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-missing-require.md",
         },
-        type: "problem",
         fixable: null,
         schema: [
             {
@@ -33,6 +32,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        type: "problem",
     },
     create(context) {
         const filePath = context.getFilename()

diff --git a/lib/rules/no-mixed-requires.js b/lib/rules/no-mixed-requires.js
@@ -67,7 +67,6 @@ const BUILTIN_MODULES = [
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description:
                 "disallow `require` calls to be mixed with regular variable declarations",
@@ -77,6 +76,11 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-mixed-requires.md",
         },
         fixable: null,
+        messages: {
+            noMixRequire: "Do not mix 'require' and other declarations.",
+            noMixCoreModuleFileComputed:
+                "Do not mix core, module, file and computed requires.",
+        },
         schema: [
             {
                 oneOf: [
@@ -98,11 +102,7 @@ module.exports = {
                 ],
             },
         ],
-        messages: {
-            noMixRequire: "Do not mix 'require' and other declarations.",
-            noMixCoreModuleFileComputed:
-                "Do not mix core, module, file and computed requires.",
-        },
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/no-new-require.js b/lib/rules/no-new-require.js
@@ -6,7 +6,6 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "disallow `new` operators with calls to `require`",
             category: "Possible Errors",
@@ -15,10 +14,11 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-new-require.md",
         },
         fixable: null,
-        schema: [],
         messages: {
             noNewRequire: "Unexpected use of new with require.",
         },
+        schema: [],
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/no-path-concat.js b/lib/rules/no-path-concat.js
@@ -158,7 +158,6 @@ function isConcat(node, sepNodes, globalScope) {
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description:
                 "disallow string concatenation with `__dirname` and `__filename`",
@@ -168,11 +167,12 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-path-concat.md",
         },
         fixable: null,
-        schema: [],
         messages: {
             usePathFunctions:
                 "Use path.join() or path.resolve() instead of string concatenation.",
         },
+        schema: [],
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/no-process-env.js b/lib/rules/no-process-env.js
@@ -10,7 +10,6 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "disallow the use of `process.env`",
             category: "Stylistic Issues",
@@ -19,10 +18,11 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-process-env.md",
         },
         fixable: null,
-        schema: [],
         messages: {
             unexpectedProcessEnv: "Unexpected use of process.env.",
         },
+        schema: [],
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/no-process-exit.js b/lib/rules/no-process-exit.js
@@ -6,7 +6,6 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "disallow the use of `process.exit()`",
             category: "Possible Errors",
@@ -15,10 +14,11 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-process-exit.md",
         },
         fixable: null,
-        schema: [],
         messages: {
             noProcessExit: "Don't use process.exit(); throw an error instead.",
         },
+        schema: [],
+        type: "suggestion",
     },
 
     create(context) {

diff --git a/lib/rules/no-restricted-import.js b/lib/rules/no-restricted-import.js
@@ -9,7 +9,6 @@ const visit = require("../util/visit-import")
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description:
                 "disallow specified modules when loaded by `import` declarations",
@@ -19,6 +18,11 @@ module.exports = {
                 "https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-restricted-import.md",
         },
         fixable: null,
+        messages: {
+            restricted:
+                // eslint-disable-next-line @mysticatea/eslint-plugin/report-message-format
+                "'{{name}}' module is restricted from being used.{{customMessage}}",
+        },
         schema: [
             {
                 type: "array",
@@ -48,11 +52,7 @@ module.exports = {
                 additionalItems: false,
             },
         ],
-        messages: {
-            restricted:
-                // eslint-disable-next-line @mysticatea/eslint-plugin/report-message-format
-                "'{{name}}' module is restricted from being used.{{customMessage}}",
-        },
+        type: "suggestion",
     },
 
     create(context) {