-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint 7.x #29
base: master
Are you sure you want to change the base?
Conversation
8297704
to
724971a
Compare
I'll note that typescript-eslint just released 3.0.0 with eslint 7 support https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0 |
22e9058
to
b68cc02
Compare
@MichaelDeBoey there is a circular dependency of waiting here:
This will never be completed according to that logic |
@eddiemonge The circular dependency will be resolved once |
a7eff6b
to
8bb0314
Compare
@mysticatea Tests are failing because rules are missing in configs. I'll add them, but I think it would be good if you check them out in order to make sure it's the correct config. |
d22c43f
to
aeea4bb
Compare
aa0379b
to
addbfd5
Compare
addbfd5
to
f9c4c6b
Compare
# Conflicts: # package.json
# Conflicts: # lib/rules/no-instanceof-array.js
# Conflicts: # .eslintrc.yml # package.json
# Conflicts: # package.json
23f1e2c
to
e2793cd
Compare
e2793cd
to
e5591ea
Compare
For people watching this PR: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/eslint-plugin-mysticatea @mysticatea We would still love to move the original repo to the new https://github.com/eslint-community though. This PR is released in |
too bad it had to come to that, but thank you for putting in the effort to get this unblocked! I'm sure Toru is just busy. Only so many hours in the day :) |
@dimitropoulos Yeah we still would like to move the original repo to the new @eslint-community org & merge all changes here I respect @mysticatea is busy, but he hasn't responded to any of our messages in a very long time & we don't want to hold back the wider community anymore, so that's why we already started with our own fork. |
ESLint v7.0.0 is released 🎉
Dependencies should be compatible with ESLint 7 too before we can merge this one:
@typescript-eslint/eslint-plugin
(ESLint v7 typescript-eslint/typescript-eslint#1550)v3.0.0
@typescript-eslint/parser
(ESLint v7 typescript-eslint/typescript-eslint#1550)v3.0.0
eslint-plugin-eslint-comments
(Support ESLint 7.x eslint-plugin-eslint-comments#38)Releaseeslint-plugin-eslint-plugin
(Support ESLint 7.x eslint-community/eslint-plugin-eslint-plugin#94)v3.0.0
eslint-plugin-node
(Support ESLint 7.x eslint-plugin-node#223)eslint-plugin-prettier
(Support ESLint 7.x prettier/eslint-plugin-prettier#292)Releaseeslint-plugin-vue
v7.0.0
Closes #28
This branch is dependent on #37, #38, #39, #40, #41, #42 & #43