Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/spain hosp icu #619

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Fix/spain hosp icu #619

merged 2 commits into from
Apr 21, 2020

Conversation

noleti
Copy link
Collaborator

@noleti noleti commented Apr 21, 2020

Related issues and PRs

Description

Disable the cumulative data for hosp and icu coming from bad Spain data source

Impacted Areas in the application

Testing

  • For most regions, hosp and ICU data removed completely (see Spanish numbers on hospitalization and ICU are wrong #595)
  • For few regions, exceptions were made. To check, compare (ESP-Castilla-La Mancha, SP-Castilla y León, ESP-C. Valenciana) generated .tsvs, observe that data should stop just before switching to cumulative (eyeballed)

@vercel
Copy link

vercel bot commented Apr 21, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/emynrwxyl
✅ Preview: https://covid19-scenarios-git-fix-spainhospicu.covid19-scenarios.now.sh

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2020

Code Climate has analyzed commit 17f35a2 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #619 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   22.12%   22.12%           
=======================================
  Files         113      113           
  Lines        2269     2269           
  Branches      335      335           
=======================================
  Hits          502      502           
  Misses       1767     1767           

@nnoll nnoll merged commit d08f19c into master Apr 21, 2020
@noleti noleti deleted the fix/spainHospICU branch April 22, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanish numbers on hospitalization and ICU are wrong
2 participants