Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed superfluous and inaccurate comments #45

Merged
merged 3 commits into from
Jun 8, 2017
Merged

Removed superfluous and inaccurate comments #45

merged 3 commits into from
Jun 8, 2017

Conversation

Seanny123
Copy link
Contributor

Just a little bit of cleaning up.

hunse and others added 3 commits June 7, 2017 11:36
@hunse
Fixed up examples/vision/mnist_single_layer.ipynb
0eb8025 
It is now more detailed, clearer, and makes use of some new helper
functions in this repository.
@Seanny123 @hunse
Removed superfluous and innacurate comments
aa35494
@hunse
Removed examples/vision/mnist_single_layer.py
657b99a 
Redundant with examples/vision/mnist_single_layer.ipynb
@hunse hunse force-pushed the vision-cleanup branch from 06a224c to 657b99a Compare June 7, 2017 15:44
@hunse
Copy link
Collaborator

hunse commented Jun 7, 2017 •
edited
Loading

I've updated mnist_single_layer.ipynb. I also removed mnist_single_layer.py, as @Seanny123 suggested in #46. I'm keeping mnist_single_layer_gui.py for now, since it shows how to run these networks in the GUI, which is a useful demonstration, though in the future maybe we just need one example showing how to run general vision networks in the GUI.

tbekolay
tbekolay approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Seanny123
Copy link
Contributor Author

Thanks for the changes Eric!

@hunse hunse merged commit 657b99a into master Jun 8, 2017
@hunse hunse deleted the vision-cleanup branch June 8, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbekolay tbekolay tbekolay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seanny123 @hunse @tbekolay