Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version updates and code polishes #395

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

seabamirum
Copy link

@seabamirum seabamirum commented Feb 28, 2024

  • Upgraded geotools, junit, maven-compiler-plugin and maven-surefire-plugin
  • Deleted unused private methods
  • Removed unnecessary else clauses that were followed by an if block with a return
  • Added missing Override annotations
  • Added static modifier to static methods when suggested by compiler
  • In makeLayerInstance, replaced deprecated newInstance method with getDeclaredConstructor().newInstance()

…eabamirum/neo4j-latest-java21

# Conflicts:
#	pom.xml
#	src/main/java/org/geotools/data/neo4j/Neo4jSpatialDataStore.java
#	src/main/java/org/geotools/data/neo4j/Neo4jSpatialDataStoreFactory.java
#	src/main/java/org/neo4j/gis/spatial/DefaultLayer.java
#	src/main/java/org/neo4j/gis/spatial/DynamicLayer.java
#	src/main/java/org/neo4j/gis/spatial/DynamicLayerConfig.java
#	src/main/java/org/neo4j/gis/spatial/OrderedEditableLayer.java
#	src/main/java/org/neo4j/gis/spatial/ShapefileImporter.java
#	src/main/java/org/neo4j/gis/spatial/SpatialDatabaseRecord.java
#	src/main/java/org/neo4j/gis/spatial/SpatialDatabaseService.java
#	src/main/java/org/neo4j/gis/spatial/SpatialTopologyUtils.java
#	src/main/java/org/neo4j/gis/spatial/WKBGeometryEncoder.java
#	src/main/java/org/neo4j/gis/spatial/WKTGeometryEncoder.java
#	src/main/java/org/neo4j/gis/spatial/attributes/PropertyMappingManager.java
#	src/main/java/org/neo4j/gis/spatial/encoders/NativePointEncoder.java
#	src/main/java/org/neo4j/gis/spatial/encoders/SimpleGraphEncoder.java
#	src/main/java/org/neo4j/gis/spatial/encoders/neo4j/Neo4jGeometry.java
#	src/main/java/org/neo4j/gis/spatial/filter/SearchCQL.java
#	src/main/java/org/neo4j/gis/spatial/index/ExplicitIndexBackedPointIndex.java
#	src/main/java/org/neo4j/gis/spatial/index/IndexManager.java
#	src/main/java/org/neo4j/gis/spatial/index/LayerGeohashPointIndex.java
#	src/main/java/org/neo4j/gis/spatial/index/LayerHilbertPointIndex.java
#	src/main/java/org/neo4j/gis/spatial/index/LayerSpaceFillingCurvePointIndex.java
#	src/main/java/org/neo4j/gis/spatial/index/LayerZOrderPointIndex.java
#	src/main/java/org/neo4j/gis/spatial/osm/OSMDataset.java
#	src/main/java/org/neo4j/gis/spatial/osm/OSMGeometryEncoder.java
#	src/main/java/org/neo4j/gis/spatial/osm/OSMImporter.java
#	src/main/java/org/neo4j/gis/spatial/osm/OSMLayer.java
#	src/main/java/org/neo4j/gis/spatial/pipes/AbstractExtractGeoPipe.java
#	src/main/java/org/neo4j/gis/spatial/pipes/AbstractGroupGeoPipe.java
#	src/main/java/org/neo4j/gis/spatial/pipes/GeoPipeline.java
#	src/main/java/org/neo4j/gis/spatial/pipes/impl/AbstractPipe.java
#	src/main/java/org/neo4j/gis/spatial/pipes/impl/Pipeline.java
#	src/main/java/org/neo4j/gis/spatial/pipes/impl/RangeFilterPipe.java
#	src/main/java/org/neo4j/gis/spatial/pipes/processing/OrthodromicDistance.java
#	src/main/java/org/neo4j/gis/spatial/procedures/SpatialProcedures.java
#	src/main/java/org/neo4j/gis/spatial/rtree/EmptyMonitor.java
#	src/main/java/org/neo4j/gis/spatial/rtree/Envelope.java
#	src/main/java/org/neo4j/gis/spatial/rtree/ProgressLoggingListener.java
#	src/main/java/org/neo4j/gis/spatial/rtree/RTreeImageExporter.java
#	src/main/java/org/neo4j/gis/spatial/rtree/RTreeIndex.java
#	src/main/java/org/neo4j/gis/spatial/rtree/RTreeMonitor.java
#	src/main/java/org/neo4j/gis/spatial/utilities/LayerUtilities.java
#	src/test/java/org/neo4j/gis/spatial/procedures/SpatialProceduresTest.java
…eabamirum/neo4j-latest-java21

# Conflicts:
#	pom.xml
@Andy2003
Copy link
Collaborator

@seabamirum Have you already signed the CLA?

@seabamirum
Copy link
Author

Yes, I have signed the CLA. I think this branch is all properly synced up now..

@Andy2003
Copy link
Collaborator

@craigtaverner May you take a look at these changes?

@Andy2003 Andy2003 force-pushed the master branch 5 times, most recently from 6844765 to bee28a4 Compare June 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants