Remove an unsafe block #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was incorrect, and [it caused UB in the wild](https://stackoverflow.com/q/78776053/7884305), because `BytesMut::reserve()` reserves **len**+X, not **capacity**+X. But even without that bug, this unsafe code was UB, since [treating uninitialized integers as initialized is UB](https://doc.rust-lang.org/stable/reference/behavior-considered-undefined.html). Fortunately, the unsafe code can be eliminated completely, and yet without zeroing the array.
knutwalker
pushed a commit
that referenced
this pull request
Jul 22, 2024
|
Thanks for fixing this! I just released 0.7.2 with this fix and yanked all previous 0.7.x releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was incorrect, and it caused UB in the wild, because
BytesMut::reserve()reserves len+X, not capacity+X.But even without that bug, this unsafe code was UB, since treating uninitialized integers as initialized is UB.
Fortunately, the unsafe code can be eliminated completely, and yet without zeroing the array.
You may consider yanking the affected versions.