Merge pull request #9160 from brs96/add-model-store-load-metrics

Add datadog metric for model store and load
neo4j · Jun 6, 2024 · 87f09a7 · 87f09a7
2 parents cafbb59 + d017934
commit 87f09a7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/model-catalog-api/src/main/java/org/neo4j/gds/core/model/ModelCatalogListener.java b/model-catalog-api/src/main/java/org/neo4j/gds/core/model/ModelCatalogListener.java
@@ -22,4 +22,8 @@
 public interface ModelCatalogListener {
 
     void onInsert(Model<?, ?, ?> model);
+
+    void onStore(Model<?, ?, ?> model);
+
+    void onLoad();
 }
diff --git a/open-model-catalog/src/test/java/org/neo4j/gds/core/model/OpenModelCatalogTest.java b/open-model-catalog/src/test/java/org/neo4j/gds/core/model/OpenModelCatalogTest.java
@@ -120,7 +120,22 @@ void shouldStoreModelsPerType() {
     @Test
     void shouldNotifyListeners() {
         var counter = new Counter();
-        modelCatalog.registerListener(model -> counter.increment());
+        modelCatalog.registerListener(new ModelCatalogListener() {
+            @Override
+            public void onInsert(Model<?, ?, ?> model) {
+                counter.increment();
+            }
+
+            @Override
+            public void onStore(Model<?, ?, ?> model) {
+
+            }
+
+            @Override
+            public void onLoad() {
+
+            }
+        });
 
         var model = Model.of(
             "testAlgo",