MS custom idp & more custom execution steps #29
+605
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszafran
reviewed
Nov 14, 2024
Comment on lines
+54
to
+56
| Stream<FederatedIdentityModel> linkedAccounts = session.users().getFederatedIdentitiesStream(realm, user); | ||
|
|
||
| linkedAccounts.forEach(identity -> { |
There was a problem hiding this comment.
Suggested change
| Stream<FederatedIdentityModel> linkedAccounts = session.users().getFederatedIdentitiesStream(realm, user); | |
| linkedAccounts.forEach(identity -> { | |
| session.users().getFederatedIdentitiesStream(realm, user).forEach(identity -> { |
|
|
||
| import org.jboss.logging.Logger; | ||
|
|
||
| public class NeonIdpCreateUserIfUnique extends AbstractIdpAuthenticator { |
There was a problem hiding this comment.
Suggested change
| public class NeonIdpCreateUserIfUnique extends AbstractIdpAuthenticator { | |
| public class NeonIdpCreateUserIfUniqueAuthenticator extends AbstractIdpAuthenticator { |
|
|
||
| @Override | ||
| public boolean configuredFor(KeycloakSession session, RealmModel realm, UserModel user) { | ||
| return false; |
There was a problem hiding this comment.
Shouldn't it be true like in IdpCreateUserIfUniqueAuthenticator?
| } | ||
|
|
||
| for (Map.Entry<String, List<String>> attr : serializedCtx.getAttributes().entrySet().stream() | ||
| .sorted(Map.Entry.comparingByKey()).toList()) { |
There was a problem hiding this comment.
Why do we need to sort here?
|
|
||
| @Override | ||
| public String getHelpText() { | ||
| return "Create User If Unique"; |
There was a problem hiding this comment.
Let's clarify here how our implementation is different from the default one.
|
|
||
| import org.jboss.logging.Logger; | ||
|
|
||
| public class NeonIdpEmailVerifyAuthenticator extends AbstractIdpAuthenticator { |
There was a problem hiding this comment.
Suggested change
| public class NeonIdpEmailVerifyAuthenticator extends AbstractIdpAuthenticator { | |
| public class NeonIdpEmailVerificationAuthenticator extends AbstractIdpAuthenticator { |
|
|
||
| public class NeonIdpEmailVerifyAuthenticator extends AbstractIdpAuthenticator { | ||
| public static final String VERIFIED_EMAIL = "VERIFIED_EMAIL"; | ||
| private static Logger logger = Logger.getLogger(IdpEmailVerificationAuthenticator.class); |
There was a problem hiding this comment.
Suggested change
| private static Logger logger = Logger.getLogger(IdpEmailVerificationAuthenticator.class); | |
| private static Logger logger = Logger.getLogger(NeonIdpEmailVerifyAuthenticator.class); |
|
|
||
| public class NeonIdpCreateUserIfUnique extends AbstractIdpAuthenticator { | ||
|
|
||
| private static Logger logger = Logger.getLogger(IdpEmailVerificationAuthenticator.class); |
There was a problem hiding this comment.
Suggested change
| private static Logger logger = Logger.getLogger(IdpEmailVerificationAuthenticator.class); | |
| private static Logger logger = Logger.getLogger(NeonIdpCreateUserIfUnique.class); |
|
|
||
| @Override | ||
| public String getId() { | ||
| return "neonmicrosoft-user-attribute-mapper"; |
There was a problem hiding this comment.
Suggested change
| return "neonmicrosoft-user-attribute-mapper"; | |
| return "neon-microsoft-user-attribute-mapper"; |
kszafran
reviewed
Nov 14, 2024
|
|
||
| import org.keycloak.broker.oidc.mappers.UserAttributeMapper; | ||
|
|
||
| public class MicrosoftUserAttributeMapper extends UserAttributeMapper { |
There was a problem hiding this comment.
Since your MicrosoftIdentityProvider extends OIDCIdentityProvider, the builtin UserAttributeMapper might already be selectable for it, I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.