-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for k8s v1.30 and deprecate v1.26 #130
Conversation
Signed-off-by: CyberHippo <[email protected]>
Signed-off-by: CyberHippo <[email protected]>
Signed-off-by: CyberHippo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CyberHippo for the contribution!
A couple of comments:
-
Let's keep K8s v1.27 since it was just EOL'd, and there may be folks still transitioning out of it.
-
The CRI-O version updates look fine here, but we need a corresponding change in the nestybox/cri-o fork. I don't believe you've had a chance do that correct?
Update regarding:
I've just done this (i.e., created the v1.30-sysbox branch in the nestybox/cri-o fork, with the patches required for CRI-O to properly allocated user-namespace IDs per pod). With this change, you should be able to build and test sysbox-deploy-k8s for K8s v1.30. Let me know if you need help with this please. |
Signed-off-by: CyberHippo <[email protected]>
Hi @ctalledo, Thanks for considering my PR and for your comments.
I reverted the deprecation of k8s v1.27 in dafedda. Thanks as well for the changes made in the nestybox/cri-o fork. I'll let take time to test it on k8s v1.30 next week and will get back to you if I need help. |
Hi @ctalledo, I finally had time to test sysbox-deploy-k8s for K8s v1.30. I followed the docs and built the docker image using The sysbox daemonset pod does not start and logs the following error:
I noticed that the node has a FrequentContainerdRestart alert and the node description shows:
I might need some of your help to debug further. |
@CyberHippo, just FYI, I'm looking into this issue now with your changes merged into a dev branch. I'm seeing problems, too, and I'm hoping we can fix them before our next release. |
Well, good luck @rodnymolina. Let me know if I can be of help. |
any progress? |
@CyberHippo, your commits have been moved to this other integration-branch/pr we have been testing over the last few weeks, so I'll go ahead and close this PR now. Thanks again for your help. |
Similar to #125
Kubernetes v1.26 is EOL since 2024-02-28 and v1.27 since 2024-07-16
Needed for nestybox/sysbox#814