Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for k8s v1.30 and deprecate v1.26 #130

Closed
wants to merge 4 commits into from

Conversation

CyberHippo
Copy link
Contributor

@CyberHippo CyberHippo commented Aug 12, 2024

Signed-off-by: CyberHippo <[email protected]>
Signed-off-by: CyberHippo <[email protected]>
Signed-off-by: CyberHippo <[email protected]>
@CyberHippo CyberHippo changed the title feat: add support for k8s v1.30 Add support for k8s v1.30 and deprecate v1.26 and v1.27 Aug 12, 2024
Copy link
Member

@ctalledo ctalledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyberHippo for the contribution!

A couple of comments:

  • Let's keep K8s v1.27 since it was just EOL'd, and there may be folks still transitioning out of it.

  • The CRI-O version updates look fine here, but we need a corresponding change in the nestybox/cri-o fork. I don't believe you've had a chance do that correct?

@ctalledo
Copy link
Member

Update regarding:

The CRI-O version updates look fine here, but we need a corresponding change in the nestybox/cri-o fork. I don't believe you've had a chance do that correct?

I've just done this (i.e., created the v1.30-sysbox branch in the nestybox/cri-o fork, with the patches required for CRI-O to properly allocated user-namespace IDs per pod).

With this change, you should be able to build and test sysbox-deploy-k8s for K8s v1.30.

Let me know if you need help with this please.

@CyberHippo
Copy link
Contributor Author

Hi @ctalledo,

Thanks for considering my PR and for your comments.

Let's keep K8s v1.27 since it was just EOL'd, and there may be folks still transitioning out of it.

I reverted the deprecation of k8s v1.27 in dafedda.

Thanks as well for the changes made in the nestybox/cri-o fork.

I'll let take time to test it on k8s v1.30 next week and will get back to you if I need help.

@CyberHippo CyberHippo changed the title Add support for k8s v1.30 and deprecate v1.26 and v1.27 Add support for k8s v1.30 and deprecate v1.26 Sep 6, 2024
@CyberHippo
Copy link
Contributor Author

CyberHippo commented Sep 24, 2024

Hi @ctalledo,

I finally had time to test sysbox-deploy-k8s for K8s v1.30.

I followed the docs and built the docker image using make sysbox-deploy-k8s-image.
I had to make a quick fix to build the image : #135
Then I deployed sysbox with the newly created image on a GKE cluster (1.30.5-gke.1014000) running Ubuntu with Containerd nodes.

The sysbox daemonset pod does not start and logs the following error:

Detected Kubernetes version v1.30
Adding K8s taint "sysbox-runtime=not-running:NoSchedule" to node ...
node/gke-beta-sysbox-792284c7-qbdz modified
Adding K8s label "crio-runtime=installing" to node ...
node/gke-beta-sysbox-792284c7-qbdz not labeled
Deploying CRI-O installer agent on the host (v1.30) ...
Running CRI-O installer agent on the host (may take several seconds) ...
Job for crio-installer.service failed because the control process exited with error code. See "systemctl status crio-installer.service" and "journalctl -xe" for details.

I noticed that the node has a FrequentContainerdRestart alert and the node description shows:

Events:
  Type     Reason                     Age                  From             Message
  ----     ------                     ----                 ----             -------
  Warning  FrequentContainerdRestart  13m                  systemd-monitor  Node condition FrequentContainerdRestart is now: True, reason: FrequentContainerdRestart, message: "Found 7 matching logs, which meets the threshold of 5"
  Warning  ContainerdStart            116s (x15 over 88m)  systemd-monitor  Starting containerd container runtime...
  Warning  OOMKilling                 86s (x174 over 66m)  kernel-monitor   (combined from similar events): Memory cgroup out of memory: Killed process 254252 (sh) total-vm:2392kB, anon-rss:68kB, file-rss:632kB, shmem-rss:0kB, UID:0 pgtables:40kB oom_score_adj:975

I might need some of your help to debug further.

@rodnymolina
Copy link
Member

@CyberHippo, just FYI, I'm looking into this issue now with your changes merged into a dev branch. I'm seeing problems, too, and I'm hoping we can fix them before our next release.

@CyberHippo
Copy link
Contributor Author

Well, good luck @rodnymolina. Let me know if I can be of help.

@choon94
Copy link

choon94 commented Nov 1, 2024

any progress?

@rodnymolina
Copy link
Member

@CyberHippo, your commits have been moved to this other integration-branch/pr we have been testing over the last few weeks, so I'll go ahead and close this PR now. Thanks again for your help.

@rodnymolina rodnymolina closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants