Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add script to generate core types (from shipped apps) #14366

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add script to generate core types (from shipped apps) #14366

wants to merge 3 commits into from
+7,193 −138

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Replace manually hardcoded types with ones copied

🖌️ UI Checklist

🚧 Tasks

  • Script review (maybe there's a better way to do this, with update nextcloud-deps/ocp)
  • Possible conflicts between major versions (might affect Desktop?)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Feb 12, 2025
@Antreesy Antreesy self-assigned this Feb 12, 2025
@nickvergessen
Copy link
Member

Should we run it as an CI step similarly to the OCP update?
https://github.com/nextcloud/spreed/blob/main/.github/workflows/update-nextcloud-ocp.yml

@Antreesy Antreesy force-pushed the fix/noid/core-types branch 3 times, most recently from 45fc2ac to becb536 Compare February 14, 2025 15:52
@Antreesy
Copy link
Contributor Author

  • Added workflow to autogenerate types (based on update-nextcloud/ocp + node)
  • Dropped openapi_files_sharing.ts (not used atm and we can test workflow with it)

@Antreesy
fix: add script and workflow to generate core types
c4c8465 
- only from selected shipped apps, as defined by script

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
chore: generate core types
43bd0eb 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: replace core types
c6e5ef9 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/core-types branch from becb536 to c6e5ef9 Compare February 14, 2025 16:04
@Antreesy Antreesy marked this pull request as ready for review February 14, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
2. developing feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen