Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.3.3 #92

Merged
merged 23 commits into from
Sep 20, 2024
Merged

Release v0.3.3 #92

merged 23 commits into from
Sep 20, 2024

Conversation

alecglen
Copy link
Collaborator

@alecglen alecglen commented Aug 8, 2024

nfl_data_py 0.3.3 fixes the test suite and resolves all submitted issues that were easy to fix while still supporting all the way back to Python 3.6 and associated dependencies. This is intended to be the final, stable v0 release before the impending upgrade to nfl_data_py 1.0.0, though bug and security patches may still be submitted in the future.

alecglen and others added 8 commits September 15, 2024 16:38
* Added Brendan's tests - passing with warnings

* Applied Brendan's fix - fixes warnings, but breaks in default-argument case

* fix default issue + some cleanup
Resolves issue with play_by_play data having incorrect old_game_id values. For example, all old_game_id values in the play_by_play_2023 for week 15 start with "2022" but they begin with "2023" in the pbp_participation_2023 data.
* Add roster tests for multiple seasons

* fix roster import indices
…ilable (#107)

* Exclude pbp participation data if the file isn't available

* Fixed incorrect error import
* add ability to import def pfr data

* add missing quotation mark
@alecglen alecglen marked this pull request as ready for review September 20, 2024 05:09
@alecglen alecglen merged commit 4b6ed7e into main Sep 20, 2024
22 checks passed
@alecglen alecglen deleted the v0.3.3 branch September 20, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants