Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spectator): setInput with object parameter for alias names (#691) #692

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

kheos31
Copy link
Contributor

@kheos31 kheos31 commented Jan 28, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Cannot compile test when we call setInput on more than one input whose one is aliased (object parameter)

Issue Number: #691

What is the new behavior?

We can compile and execute test when we call setInput on more than one input whose one is aliased (object parameter)

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

stackblitz bot commented Jan 28, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@kheos31 kheos31 changed the title fix(spectator): setInput with object parameter for alias names fix(spectator): setInput with object parameter for alias names (#691) Jan 28, 2025
@NetanelBasal NetanelBasal merged commit 25afec2 into ngneat:master Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants