Remove 'internal sets' to allow users to mock out responses. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, it was non-trivial for end users of this Airtable client to mock out responses to e.g. a list webhooks call. Whilst they could mock out a method to return a list of webhooks, they would not be able to specify what properties should be set inside those webhooks due to the 'internal set' modifier. This commit removes all occurrences of the 'internal' keyword from each Airtable object property so that users of the library can now have full controll over mocking out exact responses that this client responds with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was non-trivial for end users of this Airtable client to mock out responses to e.g. a list webhooks call. Whilst they could mock out a method to return a list of webhooks, they would not be able to specify what properties should be set inside those webhooks due to the 'internal set' modifier.
This commit removes all occurrences of the 'internal' keyword from each Airtable object property so that users of the library can now have full controll over mocking out exact responses that this client responds with.