Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor chord style #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor chord style #3

wants to merge 2 commits into from

Conversation

nickh
Copy link
Owner

@nickh nickh commented Apr 2, 2015

Trying a different visualization for chord variations. Keeps the base chord color the same and adds inline SVG opaque background images for things like minors, 7ths, etc.

- Variables for base colors
- Variables for inline SVG for chord variation backgrounds
- More chord colors
@jglovier
Copy link
Collaborator

jglovier commented Apr 2, 2015

Here's a suggestion for the design for the chords. I took some shortcuts for sake of time, and it needs a little tweaking, but you'll get the general idea:

image

@nickh
Copy link
Owner Author

nickh commented Apr 7, 2015

I like the idea, and with the chord labels on the lyric I think we can probably hide the legend by default, maybe even get rid of it. That'll look way better on smaller displays like iphones.

One of the issues I was hoping to improve on from the ASCII chord docs is being able to know the current chord from a visual cue that you don't have to scan back for. Is there something we can do for a long lyric segment on the same chord so that you don't have to scan back to the beginning of the segment?

Given the number of variations on a chord, it's probably not feasible to have different color/shade combinations for each one and still have decent contrast, so I was thinking use the color to indicate the base chord and use something else to indicate the variation. Text is probably not the best approach even if it's mostly opaque (did I just commit a huge design sin there?) but I don't have any better ideas.

@jglovier
Copy link
Collaborator

jglovier commented Apr 7, 2015

I like the idea, and with the chord labels on the lyric I think we can probably hide the legend by default, maybe even get rid of it. That'll look way better on smaller displays like iphones.

Personally, I think the legend is the most useful parts when you know the song lyrics but just need to see the chords, so I'd suggest not ditching it entirely.

Is there something we can do for a long lyric segment on the same chord so that you don't have to scan back to the beginning of the segment?

You mean other than the little labels?

@nickh
Copy link
Owner Author

nickh commented Apr 10, 2015

Personally, I think the legend is the most useful parts when you know the song lyrics but just need to see the chords, so I'd suggest not ditching it entirely.

Makes sense, maybe both sections could toggle on and off?

You mean other than the little labels?

They work great for short phrases. I get lost on the longer ones, eg:

screen shot 2015-04-09 at 8 59 23 pm

If I'm following the words, when I get to "wrist, and" I can tell that the base chord is G because of the color. But I don't know which variant I'm supposed to be playing and transitioning from to the next chord. I'd have to scan back to "Time" and lose my place and mess up the transition.

@Giangpro89
Copy link

Thankyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants