Skip to content

Commit

Permalink
Remove group_by label from stacked bar graphs (see #149) and 'across …
Browse files Browse the repository at this point in the history
…Programs' from pie chart title.
  • Loading branch information
jonathancrabtree committed Jun 22, 2023
1 parent 64ef969 commit 684b6de
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion js/donut-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function update_donut_chart_title(chart_id, dropdown) {
var new_title;

if (dropdown == 'data_type') {
new_title = 'Subjects by Assay and Anatomy across Programs';
new_title = 'Subjects by Assay and Anatomy';
} else if (dropdown == 'dcc') {
new_title = 'Samples by Anatomy and CF Program';
}
Expand Down
3 changes: 1 addition & 2 deletions js/stacked-bar-graph.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ function update_chart_title(chart_id) {
const heading = d3.select('#' + chart_id + '-title');
var y_axis = d3.select('#' + chart_id + '-y-axis option:checked').text();
var x_axis = d3.select('#' + chart_id + '-x-axis option:checked').text();
var group_by = d3.select('#' + chart_id + '-group-by option:checked').text();
var new_title = y_axis + ' by ' + x_axis + ' and ' + group_by;
var new_title = y_axis + ' by ' + x_axis;
heading.text(new_title);
}
}
Expand Down
6 changes: 3 additions & 3 deletions udashboard.html
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,17 @@ <h2>Dashboard</h2>

<div id="thumb1" class="thumbnail_chart selected">
<img src='images/chart-2.png' class="thumbnail_chart"></img><br>
Subject count by Data Type and CF Program
Subject count by Data Type
</div>

<div id="thumb2" class="thumbnail_chart">
<img src='images/chart-1.png' class="thumbnail_chart"></img><br>
File count by CF Program and Assay
File count by CF Program
</div>

<div id="thumb3" class="thumbnail_chart">
<img src='images/chart-3.png' class="thumbnail_chart"></img><br>
Subjects by Assay and Anatomy across Programs
Subjects by Assay and Anatomy
</div>

<div id="thumb4" class="thumbnail_chart">
Expand Down

0 comments on commit 684b6de

Please sign in to comment.