Skip to content

Commit

Permalink
ISSUE-#1108 Enable Floating PIP for all Firefox distributions
Browse files Browse the repository at this point in the history
- Works for Firefox, Firefox Developer Edition, and Firefox Nightly
version
  • Loading branch information
fullmetalsheep committed Feb 23, 2025
1 parent f6876d2 commit 1844fc3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Sources/AppBundle/tree/MacWindow.swift
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func isWindow(_ axWindow: AXUIElement, _ app: MacApp) -> Bool {

// Firefox non-native video fullscreen
// about:config -> full-screen-api.macos-native-full-screen -> false
app.id == "org.mozilla.firefox" && subrole == kAXUnknownSubrole
["org.mozilla.firefox", "org.mozilla.firefoxdeveloperedition", "org.mozilla.nightly"].contains(app.id ?? "") && subrole == kAXUnknownSubrole
}

// This function is referenced in the guide
Expand All @@ -271,7 +271,7 @@ func isDialogHeuristic(_ axWindow: AXUIElement, _ app: MacApp) -> Bool {
}
// Firefox: Picture in Picture window doesn't have minimize button.
// todo. bug: when firefox shows non-native fullscreen, minimize button disables for all other windows
if app.id == "org.mozilla.firefox" && axWindow.get(Ax.minimizeButtonAttr)?.get(Ax.enabledAttr) != true {
if ["org.mozilla.firefox", "org.mozilla.firefoxdeveloperedition", "org.mozilla.nightly"].contains(app.id ?? "") && axWindow.get(Ax.minimizeButtonAttr)?.get(Ax.enabledAttr) != true {
return true
}
if app.id == "com.apple.PhotoBooth" { return true }
Expand Down

0 comments on commit 1844fc3

Please sign in to comment.