Implemented 'start_pool_if_missing' logic #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @essen!
I have this patch that expands the
start_pool_if_missing
logic, allocating a new pool on demand.If a pool for a certain authority already exists, the checkout process succeed, and the request goes on as always.
In the other case, a new pool is allocated with the opts() passed to the
start_pool_if_missing
flag.This code has been working on my services for a while, and without the presumption of being perfect or to address all the open points in the pool management, it can brings an useful improvement to the current implementation.
If you have any objection or suggestion to the implementation, let me know.