Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send mention notifications on comment update #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nitely
Copy link
Owner

@nitely nitely commented Mar 24, 2017

Changes:

  • Create/update mention on comment update/edit if the comment's date is greater/equal than the notification's date.

The comment's date is always the same regardless of updates, so it should be ok. If the comment is older than the notification then that comment is already read, so I think there is no point in updating the notification. If the comment is way newer than the notification and there is a bunch of unread comments in the middle that should not matter. It's how mentions have always worked.

Needs tests before merging this thing

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 97.374% when pulling 645f05c on feature/mention_notification_on_comment_edition into 9ae914c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 97.374% when pulling 645f05c on feature/mention_notification_on_comment_edition into 9ae914c on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants