Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css_engine input test #39

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Add css_engine input test #39

merged 2 commits into from
Mar 19, 2024

Conversation

nizarmah
Copy link
Owner

@nizarmah nizarmah commented Mar 19, 2024

Follow up for #38

Adds css_engine test. This will help ensure issues like #27 are checked in future releases.

CI is enough in this case.


Clean-CSS's test is failing because of Clean CSS, not our code

The issue reported in #27 is the reason the test is failing

We'll need to either upgrade Clean CSS or remove it entirely if it doesn't minify files correctly, but that's for another PR not this one.

Copy link
Owner Author

@nizarmah nizarmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

Unfortunate that there's a failing test, but wcyd 🤷🏼

@nizarmah nizarmah merged commit 0a4662c into master Mar 19, 2024
7 of 8 checks passed
@nizarmah nizarmah deleted the test-css-engine-input branch March 19, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant