Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove actions/setup-node #1574

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Remove actions/setup-node #1574

merged 1 commit into from
Jun 8, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 8, 2024

Given we don't need any specific Node.js version in these workflows, we can use the already installed version (https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md) and get slightly faster CI and fewer things to keep up-to-date.

Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you ran it and tested

@aduh95 aduh95 merged commit 757fbd7 into nodejs:main Jun 8, 2024
1 check passed
@aduh95 aduh95 deleted the faster-ci branch June 8, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants