fixup: fix linter issues

nodejs · Jan 12, 2025 · 69a3bf3 · 69a3bf3
1 parent 01ee4c0
commit 69a3bf3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc
@@ -182,7 +182,7 @@ class BackupJob : public ThreadPoolWork {
     Local<Object> e = Local<Object>();
 
     if (backup_status_ != SQLITE_OK) {
-      CreateSQLiteError(isolate, pDest_).ToLocal(&e);
+      e = CreateSQLiteError(isolate, pDest_).ToLocalChecked();
 
       Cleanup();
 
@@ -195,7 +195,7 @@ class BackupJob : public ThreadPoolWork {
         pDest_, dest_db_.c_str(), source_->Connection(), source_db_.c_str());
 
     if (pBackup_ == nullptr) {
-      CreateSQLiteError(isolate, pDest_).ToLocal(&e);
+      e = CreateSQLiteError(isolate, pDest_).ToLocalChecked();
 
       sqlite3_close(pDest_);
 
@@ -227,9 +227,8 @@ class BackupJob : public ThreadPoolWork {
 
     if (!(backup_status_ == SQLITE_OK || backup_status_ == SQLITE_DONE ||
           backup_status_ == SQLITE_BUSY || backup_status_ == SQLITE_LOCKED)) {
-      Local<Object> e = Local<Object>();
-
-      CreateSQLiteError(env()->isolate(), backup_status_).ToLocal(&e);
+      Local<Object> e =
+          CreateSQLiteError(env()->isolate(), backup_status_).ToLocalChecked();
 
       Cleanup();
 
@@ -275,8 +274,8 @@ class BackupJob : public ThreadPoolWork {
             env()->isolate(), "Backup completed", NewStringType::kNormal)
             .ToLocalChecked();
 
-    Local<Object> e = Local<Object>();
-    CreateSQLiteError(env()->isolate(), pDest_).ToLocal(&e);
+    Local<Object> e =
+        CreateSQLiteError(env()->isolate(), pDest_).ToLocalChecked();
 
     Cleanup();
 
@@ -826,8 +825,8 @@ void DatabaseSync::Backup(const FunctionCallbackInfo<Value>& args) {
   }
 
   Local<Promise::Resolver> resolver = Promise::Resolver::New(env->context())
-    .ToLocalChecked()
-    .As<Promise::Resolver>();
+                                          .ToLocalChecked()
+                                          .As<Promise::Resolver>();
 
   args.GetReturnValue().Set(resolver->GetPromise());
 

diff --git a/test/parallel/test-sqlite-backup.mjs b/test/parallel/test-sqlite-backup.mjs
@@ -1,4 +1,4 @@
-import common from '../common/index.js';
+import * as common from '../common/index.mjs';
 import tmpdir from '../common/tmpdir.js';
 import { join } from 'path';
 import { DatabaseSync } from 'node:sqlite';
@@ -58,7 +58,8 @@ test('database backup', async (t) => {
   const backup = new DatabaseSync(destDb);
   const rows = backup.prepare('SELECT * FROM data').all();
 
-  // The source database has two pages - using the default page size -, so the progress function should be called once (the last call is not made since
+  // The source database has two pages - using the default page size -,
+  // so the progress function should be called once (the last call is not made since
   // the promise resolves)
   t.assert.strictEqual(progressFn.mock.calls.length, 1);
   t.assert.deepStrictEqual(rows, [
@@ -80,4 +81,3 @@ test('database backup fails when dest file is not writable', (t) => {
     message: 'attempt to write a readonly database'
   }));
 });
-