-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tty: fix links for terminal colors #54596
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54596 +/- ##
=======================================
Coverage 87.33% 87.34%
=======================================
Files 649 649
Lines 182570 182570
Branches 35040 35027 -13
=======================================
+ Hits 159454 159462 +8
+ Misses 16390 16381 -9
- Partials 6726 6727 +1
|
This doesn't need a CI to land, and has an approval: |
This changes source code (even if it's comments) so needs a full CI. |
Out of curiosity, what's the reason behind that? |
It's an extra level of checks to guard against, e.g. accidentally commenting out code. I also think at one point |
CI had a few flakes, can it be resumed? |
This PR updates the links for TTY's terminal colors.
For Terminator, according to author of the original link (The bolded
Here
is the new link):For rxvt-unicode-24bit, the link was changed to that mentioned by https://github.com/termstandard/colors.