Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty: fix links for terminal colors #54596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

This PR updates the links for TTY's terminal colors.

For Terminator, according to author of the original link (The bolded Here is the new link):

For Terminator users, there is a branch for GTK+3 version, which supports true colors and much more, but it's not yet merged in the master and not yet released as well. Here is the bug for pushing it upstream. So if you want to help this - you can test it more, write patches and ping developers. Looks like this one is almost ready, I see no big stoppers against merging this branch in the master and releasing a new version of Terminator.

For rxvt-unicode-24bit, the link was changed to that mentioned by https://github.com/termstandard/colors.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem. labels Aug 27, 2024
@RedYetiDev RedYetiDev removed the needs-ci PRs that need a full CI run. label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (a7271ab) to head (9519136).
Report is 266 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54596   +/-   ##
=======================================
  Coverage   87.33%   87.34%           
=======================================
  Files         649      649           
  Lines      182570   182570           
  Branches    35040    35027   -13     
=======================================
+ Hits       159454   159462    +8     
+ Misses      16390    16381    -9     
- Partials     6726     6727    +1     
Files with missing lines Coverage Δ
lib/internal/tty.js 97.04% <100.00%> (ø)

... and 28 files with indirect coverage changes

@RedYetiDev
Copy link
Member Author

This doesn't need a CI to land, and has an approval: author ready?

@richardlau
Copy link
Member

This doesn't need a CI to land, and has an approval: author ready?

This changes source code (even if it's comments) so needs a full CI.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024
@nodejs-github-bot
Copy link
Collaborator

@RedYetiDev RedYetiDev added the needs-ci PRs that need a full CI run. label Sep 3, 2024
@RedYetiDev
Copy link
Member Author

This changes source code (even if it's comments) so needs a full CI.

Out of curiosity, what's the reason behind that?

@richardlau
Copy link
Member

This changes source code (even if it's comments) so needs a full CI.

Out of curiosity, what's the reason behind that?

It's an extra level of checks to guard against, e.g. accidentally commenting out code. I also think at one point js2c couldn't handle some Unicode characters (possibly fixed now?).
Also https://www.bleepingcomputer.com/news/security/invisible-characters-could-be-hiding-backdoors-in-your-javascript-code/.

@RedYetiDev
Copy link
Member Author

CI had a few flakes, can it be resumed?

@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants