test: remove unused common utilities #54825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
RedYetiDev
commented
Sep 7, 2024
| @@ -1,5 +1,4 @@ | |||
| 'use strict'; | |||
| require('../common'); | |||
There was a problem hiding this comment.
Review note: This was removed because this file doesn't need to load ../common in order to function. I can make a seperate PR if needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54825 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 651 651
Lines 183387 183387
Branches 35794 35802 +8
=======================================
+ Hits 161494 161497 +3
+ Misses 15166 15161 -5
- Partials 6727 6729 +2 |
jasnell
approved these changes
Sep 7, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Sep 8, 2024
MoLow
approved these changes
Sep 8, 2024
|
This PR is currently blocked from landing due to unreliable CI. |
|
Is that still the case. The CI LGTM, it passed everything except for a few flakes |
|
PR should be rebased with a fresh CI run. |
RedYetiDev
force-pushed
the
remove-extra-common
branch
from
7e2ade6
to
0724727
Compare
|
Rebase complete, can someone start a CI? |
RedYetiDev
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
Sep 21, 2024
PR-URL: #54825 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
|
Landed in 5116578 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54825 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54825 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes files from
test/common/...that aren't used in Node.js's testing.