Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove getCallSite from common #54947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: remove getCallSite from common #54947

wants to merge 1 commit into from
+3 −25

Conversation

RedYetiDev
Copy link
Member

Now that #54380 landed, common no longer needs it's own implementation.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 14, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (a65105e) to head (e4ec337).
Report is 69 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54947      +/-   ##
==========================================
- Coverage   88.07%   88.06%   -0.01%     
==========================================
  Files         651      651              
  Lines      183538   183538              
  Branches    35862    35864       +2     
==========================================
- Hits       161647   161641       -6     
- Misses      15136    15144       +8     
+ Partials     6755     6753       -2

see 23 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62537/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024
@RedYetiDev
Copy link
Member Author

CI LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedYetiDev @nodejs-github-bot @lpinca