lib, tools: remove duplicate requires #54958
Closed
+29
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
RedYetiDev
changed the title
RedYetiDev
force-pushed
the
remove-duplicate-requires
branch
from
125d088
to
51d2a72
Compare
|
I need to work around a few kinks it seems... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54958 +/- ##
==========================================
+ Coverage 88.05% 88.07% +0.01%
==========================================
Files 651 652 +1
Lines 183387 183562 +175
Branches 35794 35866 +72
==========================================
+ Hits 161488 161664 +176
+ Misses 15160 15142 -18
- Partials 6739 6756 +17
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #54892.
The first commit is that PR.
The second commit (A) removes duplicate requires, and (B) updates the lint rule to check if a require in a function is unneeded due to a top-level require.