Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup 5.x auto release #3111

Draft
wants to merge 1 commit into
base: v5.x
Choose a base branch
from

Conversation

mweberxyz
Copy link
Contributor

@mweberxyz mweberxyz commented Apr 13, 2024

See #3110 for details. Both should merge at the same time.

This relates to...

#3103

Rationale

Add 5.x specific deployment logic to v5.x branch

Changes

Backport release workflow and release script from main, ensure change logs are generated against previous 5.x release, ensure tag on npm publish is five, and remove publish-undici-types workflow (now taken care of during release workflow)

Notes

Assuming the release environment is set to Protected branches only, branch protection rules must be added for v5.x branch, as this change will enable automated release on push.

Alternatively (for added security) -- the release environment should be limited to exactly the main or v5.x branch, in addition to adding branch protection rules to v5.x.

If the following protections are added:
CleanShot 2024-04-13 at 11 13 25@2x

Then this is what a malicious branch and workflow run would look like, with the release blocked:
https://github.com/mweberxyz/nodejs-undici/commits/malicious/
https://github.com/mweberxyz/nodejs-undici/actions/runs/8674454300

Status

@mweberxyz mweberxyz marked this pull request as draft April 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant