Add fallback for charge calculation when capacity sysfs is missing
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng capacity sysfs.
|
|
|
Energy usage also fails, but that is yet another PR. |
|
Hi, thank you very much for your PR and congrats for your first Rust-related PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Dell XPS 13 9345 Snapdragon X, the
capacitysysfs file is empty. So Resources doesn't show the charge.However, Gnome does show proper charge. That charge can be calculated properly from
energy_now/energy_full. So this PR adds logic for that.My battery doesn't show up in Resources at all by the way, cause the path is
/power_supply/qcom-battmgr-bat, but that's for another PR.This is my first PR on a Rust project, so let me know if there are things missing or whatsoever.