CODEOWNERS: Overhaul in order to enable required reviews #17327

carlescufi · 2024-09-16T10:36:11Z

Replaces #15698

In preparation for the enabling of the GitHub "Require reviews from Code Owners" branch protection setting, reorganize the Codeowners file so that Vestavind is aware of changes in the files it needs to oversee.

See also: https://nordicsemi.atlassian.net/wiki/spaces/SPG/pages/635604878/CODEOWNERS+file

NordicBuilder · 2024-09-16T10:39:12Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 21

Inputs:

Sources:

sdk-nrf: PR head: df513db8df84a0f6a22f7f7b45f8e30eb7bfe80e

more details

sdk-nrf:

PR head: df513db8df84a0f6a22f7f7b45f8e30eb7bfe80e
merge base: 0063d04074e9b8927262eee0fecf518b5d2dd7c6
target head (main): cfb2a11d013959f2fa68a1dc9460a1cf1c6fda82
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (1)

CODEOWNERS

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain
◻️ Build twister
◻️ Integration tests

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi

Note: This message is automatically posted and updated by the CI

CODEOWNERS

hubertmis · 2024-09-16T16:15:40Z

CODEOWNERS

-/lib/gcf_sms/                             @eivindj-nordic
-/lib/nrf_modem_lib/                       @rlubos @lemrey
+/lib/gcf_sms/                             @nrfconnect/ncs-modem
+/lib/nrf_modem_lib/                       @nrfconnect/ncs-co-networking @nrfconnect/ncs-modem
 /lib/edge_impulse/                        @pdunaj


How about allocating this to SI team instead of the team leader?

@pdunaj can you please let me know which teams to create?

CODEOWNERS

plskeggs

LGTM for nrfcloud

CODEOWNERS

thst-nordic

The reason for this overhaul is to allow PR authors to merge small changes faster.

We should aim to replace as many individual accounts with teams to avoid delays due to absences. It looks like good progress towards this already.

carlescufi · 2024-09-17T11:50:45Z

subsys/fw_info and tests/subsys/fw_info should go to Pluto

Fixed

hubertmis

Still, I would replace multiple @pdunaj with relevant teams. But I guess we can do that later.

CODEOWNERS

carlescufi · 2024-09-18T11:06:03Z

Still, I would replace multiple @pdunaj with relevant teams. But I guess we can do that later.

Currently discussing it with him

pdunaj · 2024-09-18T12:44:28Z

Still, I would replace multiple @pdunaj with relevant teams. But I guess we can do that later.

Currently discussing it with him

Pushed the change as a commit to this PR. Please squash if ok.

CODEOWNERS

SeppoTakalo · 2024-09-19T09:37:45Z

@carlescufi

Final changes (hopefully) for my team.
I think these can be assigned to ncs-iot-oulu instead of individuals

/samples/cellular/slm_shell/
/subsys/net/lib/ftp_client/
/lib/modem_jwt/ (maybe ncs-modem as well)
/tests/lib/modem_jwt/

In preparation for the enabling of the GitHub "Require reviews from Code Owners" branch protection setting, reorganize the Codeowners file so that Vestavind is aware of changes in the files it needs to oversee. See also: https://nordicsemi.atlassian.net/wiki/spaces/SPG/pages/635604878/CODEOWNERS+file Signed-off-by: Carles Cufi <[email protected]>

carlescufi · 2024-09-19T10:15:30Z

@carlescufi

Final changes (hopefully) for my team. I think these can be assigned to ncs-iot-oulu instead of individuals

/samples/cellular/slm_shell/

/subsys/net/lib/ftp_client/

/lib/modem_jwt/ (maybe ncs-modem as well)

/tests/lib/modem_jwt/

Done

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 16, 2024

carlescufi force-pushed the codeowners-update branch from d9de2aa to b5add06 Compare September 16, 2024 10:43

carlescufi requested a review from a team September 16, 2024 11:06

gmarull approved these changes Sep 16, 2024

View reviewed changes

nordicjm reviewed Sep 16, 2024

View reviewed changes

CODEOWNERS Show resolved Hide resolved

nordicjm reviewed Sep 16, 2024

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

carlescufi force-pushed the codeowners-update branch from b5add06 to 7d17850 Compare September 16, 2024 12:07

carlescufi requested a review from nordicjm September 16, 2024 12:07

carlescufi force-pushed the codeowners-update branch from 7d17850 to fdb6eff Compare September 16, 2024 12:19

carlescufi requested review from thst-nordic, plskeggs, lemrey and a team September 16, 2024 12:20

carlescufi force-pushed the codeowners-update branch 2 times, most recently from f86e472 to 50623cc Compare September 16, 2024 12:24

bjarki-andreasen approved these changes Sep 16, 2024

View reviewed changes

nordicjm approved these changes Sep 16, 2024

View reviewed changes

hubertmis reviewed Sep 16, 2024

View reviewed changes

plskeggs approved these changes Sep 16, 2024

View reviewed changes

lemrey approved these changes Sep 17, 2024

View reviewed changes

hakonfam requested changes Sep 17, 2024

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

CODEOWNERS Outdated Show resolved Hide resolved

nordic-piks approved these changes Sep 17, 2024

View reviewed changes

carlescufi force-pushed the codeowners-update branch from 50623cc to c8d4668 Compare September 17, 2024 08:43

carlescufi requested review from hubertmis, ankuns and hakonfam September 17, 2024 08:43

carlescufi force-pushed the codeowners-update branch from c8d4668 to d9e9c04 Compare September 17, 2024 08:47

thst-nordic approved these changes Sep 17, 2024

View reviewed changes

carlescufi requested a review from oyvindronningstad September 17, 2024 11:50

carlescufi force-pushed the codeowners-update branch from a3bb673 to e4f56e4 Compare September 17, 2024 11:53

oyvindronningstad approved these changes Sep 17, 2024

View reviewed changes

SeppoTakalo approved these changes Sep 17, 2024

View reviewed changes

carlescufi force-pushed the codeowners-update branch 2 times, most recently from ff42002 to 1e8e8ed Compare September 17, 2024 12:30

jhn-nordic approved these changes Sep 17, 2024

View reviewed changes

shanthanordic approved these changes Sep 17, 2024

View reviewed changes

hubertmis approved these changes Sep 17, 2024

View reviewed changes

PerMac approved these changes Sep 17, 2024

View reviewed changes

nordic-segl approved these changes Sep 17, 2024

View reviewed changes

koffes approved these changes Sep 17, 2024

View reviewed changes

nordic-hani approved these changes Sep 18, 2024

View reviewed changes

nordicjm reviewed Sep 18, 2024

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

carlescufi force-pushed the codeowners-update branch from 1e8e8ed to 962ab54 Compare September 18, 2024 10:56

carlescufi force-pushed the codeowners-update branch from a1a4714 to 123f42c Compare September 18, 2024 12:58

hubertmis approved these changes Sep 18, 2024

View reviewed changes

maciejpietras reviewed Sep 19, 2024

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

carlescufi force-pushed the codeowners-update branch 2 times, most recently from 7b53e4e to 962b5e8 Compare September 19, 2024 09:17

carlescufi requested a review from maciejpietras September 19, 2024 10:11

carlescufi force-pushed the codeowners-update branch from 962b5e8 to df513db Compare September 19, 2024 10:15

maciejpietras approved these changes Sep 19, 2024

View reviewed changes

carlescufi merged commit 1425a59 into nrfconnect:main Sep 19, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CODEOWNERS: Overhaul in order to enable required reviews #17327

CODEOWNERS: Overhaul in order to enable required reviews #17327

carlescufi commented Sep 16, 2024

NordicBuilder commented Sep 16, 2024 •

edited

Loading

hubertmis Sep 16, 2024

carlescufi Sep 16, 2024

plskeggs left a comment

thst-nordic left a comment •

edited

Loading

carlescufi commented Sep 17, 2024

hubertmis left a comment

carlescufi commented Sep 18, 2024

pdunaj commented Sep 18, 2024

SeppoTakalo commented Sep 19, 2024

carlescufi commented Sep 19, 2024

CODEOWNERS: Overhaul in order to enable required reviews #17327

CODEOWNERS: Overhaul in order to enable required reviews #17327

Conversation

carlescufi commented Sep 16, 2024

NordicBuilder commented Sep 16, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

hubertmis Sep 16, 2024

Choose a reason for hiding this comment

carlescufi Sep 16, 2024

Choose a reason for hiding this comment

plskeggs left a comment

Choose a reason for hiding this comment

thst-nordic left a comment • edited Loading

Choose a reason for hiding this comment

carlescufi commented Sep 17, 2024

hubertmis left a comment

Choose a reason for hiding this comment

carlescufi commented Sep 18, 2024

pdunaj commented Sep 18, 2024

SeppoTakalo commented Sep 19, 2024

carlescufi commented Sep 19, 2024

NordicBuilder commented Sep 16, 2024 •

edited

Loading

thst-nordic left a comment •

edited

Loading