include/zephyr/ipc/ipc_service.h:155 trailing whitespace

samples/subsys/ipc/ipc_service/icmsg/src/main.c:152 do not use C99 // comments

subsys/ipc/ipc_service/lib/icmsg.c:173 "(foo*)" should be "(foo *)"

subsys/ipc/ipc_service/lib/icmsg.c:205 trailing whitespace

subsys/ipc/ipc_service/lib/icmsg.c:339 trailing whitespace

Process completed with exit code 5.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details Commit 5ffb19c1eb: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Asserts and removed unused code" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit e511099172: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Code cleanup" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit b2197452ae: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Fix infinite unbound" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit 0e1e42b47f: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Check unbound in icmsg sample" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit 99b0105f8f: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Working icmsg sample for nRF53" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit 8dd8d86717: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "All the code is in, ready to run it." 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit 6e71410114: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Draft of mbox callback handler" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit ec1daef91c: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Draft of icmsg_open" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit 62017bfb7c: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Add unbound DTS option and adjust pbuf for session handshake" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing Commit 1b2526b68b: 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "IPC service API update" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing

Git conflict markers and whitespace errors are not allowed in added changes e5110991726e6cea69fe9a772554174ceccefb5f: subsys/ipc/ipc_service/lib/icmsg.c:205: trailing whitespace. e5110991726e6cea69fe9a772554174ceccefb5f: subsys/ipc/ipc_service/lib/icmsg.c:339: trailing whitespace. 6e71410114bd9b097068bc953b16f09251434399: subsys/ipc/ipc_service/lib/icmsg.c:311: trailing whitespace. 1b2526b68bf2031b7cc2e2753f4bbbf9dad8d32c: include/zephyr/ipc/ipc_service.h:155: trailing whitespace.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. TRAILING_WHITESPACE: trailing whitespace File:include/zephyr/ipc/ipc_service.h Line:155 LONG_LINE: line length of 113 exceeds 100 columns File:include/zephyr/ipc/pbuf.h Line:126 LONG_LINE: line length of 113 exceeds 100 columns File:include/zephyr/ipc/pbuf.h Line:127 C99_COMMENTS: do not use C99 // comments File:samples/subsys/ipc/ipc_service/icmsg/src/main.c Line:152 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:subsys/ipc/ipc_service/lib/icmsg.c Line:173 TYPO_SPELLING: 'initalized' may be misspelled - perhaps 'initialized'? File:subsys/ipc/ipc_service/lib/icmsg.c Line:174 TRAILING_WHITESPACE: trailing whitespace File:subsys/ipc/ipc_service/lib/icmsg.c Line:205 TRAILING_WHITESPACE: trailing whitespace File:subsys/ipc/ipc_service/lib/icmsg.c Line:339 LINE_SPACING: Missing a blank line after declarations File:subsys/ipc/ipc_service/lib/pbuf.c Line:301

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 5ffb19c1eb479ae3154c6ef901e6021c902288d9: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. e5110991726e6cea69fe9a772554174ceccefb5f: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. b2197452ae032880c440b13a9d16e93dcb88e096: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. 0e1e42b47f018a21ea30cdf5606948449265ba78: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. 99b0105f8fbfccf07d9b99300a558d8da95dd19e: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. 8dd8d86717689c2cd159ca9c0e1a0a7d7f1cab74: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. 6e71410114bd9b097068bc953b16f09251434399: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. ec1daef91cd4a00040611a4a7d7f4862be19f432: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. 62017bfb7cc996a017b31fccff6026afbcf609d6: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries. 1b2526b68bf2031b7cc2e2753f4bbbf9dad8d32c: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.

Process completed with exit code 1.

include/zephyr/ipc/pbuf.h:126 line length of 113 exceeds 100 columns

include/zephyr/ipc/pbuf.h:127 line length of 113 exceeds 100 columns

subsys/ipc/ipc_service/lib/icmsg.c:174 'initalized' may be misspelled - perhaps 'initialized'?

subsys/ipc/ipc_service/lib/pbuf.c:301 Missing a blank line after declarations

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - * + * File:include/zephyr/ipc/ipc_service.h Line:156 You may want to run clang-format on this change: - volatile uint32_t *rd_idx_loc; /* Address of the variable holding - * index value of the first valid byte - * in data[]. - */ - volatile uint32_t *handshake_loc;/* Address of the variable holding - * handshake information. - */ - volatile uint32_t *wr_idx_loc; /* Address of the variable holding - * index value of the first free byte - * in data[]. - */ - uint32_t dcache_alignment; /* CPU data cache line size in bytes. - * Used for validation - TODO: To be - * replaced by flags. - */ - uint32_t len; /* Length of data[] in bytes. */ - uint8_t *data_loc; /* Location of the data[]. */ + volatile uint32_t *rd_idx_loc; /* Address of the variable holding + * index value of the first valid byte + * in data[]. + */ + volatile uint32_t *handshake_loc; /* Address of the variable holding + * handshake information. + */ + volatile uint32_t *wr_idx_loc; /* Address of the variable holding + * index value of the first free byte + * in data[]. + */ + uint32_t dcache_alignment; /* CPU data cache line size in bytes. + * Used for validation - TODO: To be + * replaced by flags. + */ + uint32_t len; /* Length of data[] in bytes. */ + uint8_t *data_loc; /* Location of the data[]. */ File:include/zephyr/ipc/pbuf.h Line:67 You may want to run clang-format on this change: -#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \ -{ \ - .rd_idx_loc = (uint32_t *)(mem_addr), \ - .handshake_loc = use_handshake ? (uint32_t *)((uint8_t *)(mem_addr) + \ - _PBUF_IDX_SIZE) : NULL, \ - .wr_idx_loc = (uint32_t *)((uint8_t *)(mem_addr) + MAX(dcache_align, \ - (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \ - .data_loc = (uint8_t *)((uint8_t *)(mem_addr) + \ - MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE), \ - .len = (uint32_t)((uint32_t)(size) - MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \ - _PBUF_IDX_SIZE), \ - .dcache_alignment = (dcache_align), \ -} +#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \ + { \ + .rd_idx_loc = (uint32_t *)(mem_addr), \ + .handshake_loc = use_handshake \ + ? (uint32_t *)((uint8_t *)(mem_addr) + _PBUF_IDX_SIZE) \ + : NULL, \ + .wr_idx_loc = \ + (uint32_t *)((uint8_t *)(mem_addr) + \ + MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \ + .data_loc = \ + (uint8_t *)((uint8_t *)(mem_addr) + \ + MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + \ + _PBUF_IDX_SIZE), \ + .len = (uint32_t)((uint32_t)(size) - \ + MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \ + _PBUF_IDX_SIZE), \ + .dcache_alignment = (dcache_align), \ + } File:include/zephyr/ipc/pbuf.h Line:131 You may want to run clang-format on this change: -#define PBUF_DEFINE(name, mem_addr, size, dcache_align, use_handshake, compatibility) \ - BUILD_ASSERT(dcache_align >= 0, \ - "Cache line size must be non negative."); \ - BU

include/zephyr/ipc/ipc_service.h:156 - * + *

include/zephyr/ipc/pbuf.h:67 - volatile uint32_t *rd_idx_loc; /* Address of the variable holding - * index value of the first valid byte - * in data[]. - */ - volatile uint32_t *handshake_loc;/* Address of the variable holding - * handshake information. - */ - volatile uint32_t *wr_idx_loc; /* Address of the variable holding - * index value of the first free byte - * in data[]. - */ - uint32_t dcache_alignment; /* CPU data cache line size in bytes. - * Used for validation - TODO: To be - * replaced by flags. - */ - uint32_t len; /* Length of data[] in bytes. */ - uint8_t *data_loc; /* Location of the data[]. */ + volatile uint32_t *rd_idx_loc; /* Address of the variable holding + * index value of the first valid byte + * in data[]. + */ + volatile uint32_t *handshake_loc; /* Address of the variable holding + * handshake information. + */ + volatile uint32_t *wr_idx_loc; /* Address of the variable holding + * index value of the first free byte + * in data[]. + */ + uint32_t dcache_alignment; /* CPU data cache line size in bytes. + * Used for validation - TODO: To be + * replaced by flags. + */ + uint32_t len; /* Length of data[] in bytes. */ + uint8_t *data_loc; /* Location of the data[]. */

include/zephyr/ipc/pbuf.h:131 -#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \ -{ \ - .rd_idx_loc = (uint32_t *)(mem_addr), \ - .handshake_loc = use_handshake ? (uint32_t *)((uint8_t *)(mem_addr) + \ - _PBUF_IDX_SIZE) : NULL, \ - .wr_idx_loc = (uint32_t *)((uint8_t *)(mem_addr) + MAX(dcache_align, \ - (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \ - .data_loc = (uint8_t *)((uint8_t *)(mem_addr) + \ - MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE), \ - .len = (uint32_t)((uint32_t)(size) - MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \ - _PBUF_IDX_SIZE), \ - .dcache_alignment = (dcache_align), \ -} +#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \ + { \ + .rd_idx_loc = (uint32_t *)(mem_addr), \ + .handshake_loc = use_handshake \ + ? (uint32_t *)((uint8_t *)(mem_addr) + _PBUF_IDX_SIZE) \ + : NULL, \ + .wr_idx_loc = \ + (uint32_t *)((uint8_t *)(mem_addr) + \ + MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \ + .data_loc = \ + (uint8_t *)((uint8_t *)(mem_addr) + \ + MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + \ + _PBUF_IDX_SIZE), \ + .len = (uint32_t)((uint32_t)(size) - \ + MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \ + _PBUF_IDX_SIZE), \ + .dcache_alignment = (dcache_align), \ + }

include/zephyr/ipc/pbuf.h:165 -#define PBUF_DEFINE(name, mem_addr, size, dcache_align, use_handshake, compatibility) \ - BUILD_ASSERT(dcache_align >= 0, \ - "Cache line size must be non negative."); \ - BUILD_ASSERT((size) > 0 && IS_PTR_ALIGNED_BYTES(size, _PBUF_IDX_SIZE), \ - "Incorrect size."); \ - BUILD_ASSERT(IS_PTR_ALIGNED_BYTES(mem_addr, MAX(dcache_align, _PBUF_IDX_SIZE)), \ - "Misaligned memory."); \ - BUILD_ASSERT(size >= (MAX(dcache_align, _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE + \ - _PBUF_MIN_DATA_LEN), "Insufficient size."); \ - BUILD_ASSERT(!(compatibility) || (dcache_align) >= 8, \ - "Data cache alignment must be at least 8 if compatibility is enabled.");\ - static PBUF_MAYBE_CONST struct pbuf_cfg cfg_##name = \ - PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake); \ - static struct pbuf name = { \ - .cfg = &cfg_##name, \ +#define PBUF_DEFINE(name, mem_addr, size, dcache_align, use_handshake, compatibility) \ + BUILD_ASSERT(dcache_align >= 0, "Cache line size must be non negative."); \ + BUILD_ASSERT((size) > 0 && IS_PTR_ALIGNED_BYTES(size, _PBUF_IDX_SIZE), "Incorrect size."); \ + BUILD_ASSERT(IS_PTR_ALIGNED_BYTES(mem_addr, MAX(dcache_align, _PBUF_IDX_SIZE)), \ + "Misaligned memory."); \ + BUILD_ASSERT( \ + size >= (MAX(dcache_align, _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE + _PBUF_MIN_DATA_LEN), \ + "Insufficient size."); \ + BUILD_ASSERT(!(compatibility) || (dcache_align) >= 8, \ + "Data cache alignment must be at least 8 if compatibility is enabled."); \ + static PBUF_MAYBE_CONST struct pbuf_cfg cfg_##name = \ + PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake); \ + static struct pbuf name = { \ + .cfg = &cfg_##name, \

samples/subsys/ipc/ipc_service/icmsg/src/main.c:140 - .cb = { - .bound = ep_bound, - .unbound = ep_unbound, - .received = ep_recv, - .error = ep_error, - }, + .cb = + { + .bound = ep_bound, + .unbound = ep_unbound, + .received = ep_recv, + .error = ep_error, + },

samples/subsys/ipc/ipc_service/icmsg/src/main.c:153 - //nrf53_cpunet_enable(true); printk("sample"); + // nrf53_cpunet_enable(true); printk("sample");

samples/subsys/ipc/ipc_service/icmsg/src/main.c:197 - nrf53_cpunet_enable(true); printk("sample 2"); + nrf53_cpunet_enable(true); + printk("sample 2");

samples/subsys/ipc/ipc_service/icmsg/src/main.c:230 - nrf53_cpunet_enable(true); printk("sample 2"); + nrf53_cpunet_enable(true); + printk("sample 2");

subsys/ipc/ipc_service/backends/ipc_icbmsg.c:1456 -#define DEFINE_BACKEND_DEVICE(i) \ - SYS_BITARRAY_DEFINE_STATIC(tx_usage_bitmap_##i, DT_INST_PROP(i, tx_blocks)); \ - SYS_BITARRAY_DEFINE_STATIC(rx_hold_bitmap_##i, DT_INST_PROP(i, rx_blocks)); \ - PBUF_DEFINE(tx_icbmsg_pb_##i, \ - GET_MEM_ADDR_INST(i, tx), \ - GET_ICMSG_SIZE_INST(i, tx, rx), \ - GET_CACHE_ALIGNMENT(i)); \ - PBUF_DEFINE(rx_icbmsg_pb_##i, \ - GET_MEM_ADDR_INST(i, rx), \ - GET_ICMSG_SIZE_INST(i, rx, tx), \ - GET_CACHE_ALIGNMENT(i)); \ - static struct backend_data backend_data_##i = { \ - .control_data = { \ - .tx_pb = &tx_icbmsg_pb_##i, \ - .rx_pb = &rx_icbmsg_pb_##i, \ - } \ - }; \ - static MAYBE_CONST struct icbmsg_config backend_config_##i = \ - { \ - .control_config = { \ - .mbox_tx = MBOX_DT_SPEC_INST_GET(i, tx), \ - .mbox_rx = MBOX_DT_SPEC_INST_GET(i, rx), \ - .unbound_mode = ICMSG_UNBOUND_MODE_DISABLE, /* TODO: */ \ - }, \ - .tx = { \ - .blocks_ptr = (uint8_t *)GET_BLOCKS_ADDR_INST(i, tx, rx), \ - .block_count = DT_INST_PROP(i, tx_blocks), \ - .block_size = GET_BLOCK_SIZE_INST(i, tx, rx), \ - }, \ - .rx = { \ - .blocks_ptr = (uint8_t *)GET_BLOCKS_ADDR_INST(i, rx, tx), \ - .block_count = DT_INST_PROP(i, rx_blocks), \ - .block_size = GET_BLOCK_SIZE_INST(i, rx, tx), \ - }, \ - .tx_usage_bitmap = &tx_usage_bitmap_##i, \ - .rx_hold_bitmap = &rx_hold_bitmap_##i, \ - }; \ - BUILD_ASSERT(IS_POWER_OF_TWO(GET_CACHE_ALIGNMENT(i)), \ - "This module supports only power of two cache alignment"); \ - BUILD_ASSERT((GET_BLOCK_SIZE_INST(i, tx, rx) >= GET_CACHE_ALIGNMENT(i)) && \ - (GET_BLOCK_SIZE_INST(i, tx, rx) < \ - GET_MEM_SIZE_INST(i, tx)), \ - "TX region is too small for provided number of blocks"); \ - BUILD_ASSERT((GET_BLOCK_SIZE_INST(i, rx, tx) >= GET_CACHE_ALIGNMENT(i)) && \ - (GET_BLOCK_SIZE_INST(i, rx, tx) < \ - GET_MEM_SIZE_INST(i, rx)), \ - "RX region is too small for provided number of blocks"); \ - BUILD_ASSERT(DT_INST_PROP(i, rx_blocks) <= 256, "Too many RX blocks"); \ - BUILD_ASSERT(DT_INST_PROP(i, tx_blocks) <= 256, "Too many TX blocks"); \ - DEVICE_DT_INST_DEFINE(i, \ - &backend_init, \ - NULL, \ - &backend_data_##i, \ - &backend_config_##i, \ - POST_KERNEL, \ - CONFIG_IPC_SERVICE_REG_BACKEND_PRIORITY, \ - &backend_ops); +#define DEFINE_BACKEND_DEVICE(i) \ + SYS_BITARRAY_DEFINE_STATIC(tx_usage_bitmap_##i, DT_INST_PROP(i, tx_blocks)); \ + SYS_BITARRAY_DEFINE_STATIC(rx_hold_bitmap_##i, DT_INST_PROP(i, rx_blocks)); \ + PBUF_DEFINE(tx_icbmsg_pb_##i, GET_MEM_ADDR_INST(i, tx), GET_ICMSG_SIZE_INST(i, tx, rx), \ + GET_CACHE_ALIGNMENT(i)); \ + PBUF_DEFINE(rx_icbmsg_pb_##i, GET_MEM_ADDR_INST(i, rx), GET_ICMSG_SIZE_INST(i, rx, tx), \ + GET_CACHE_ALIGNMENT(i)); \ + static struct backend_data backend_data_##i = {.control_data = { \ + .tx_pb = &tx_icbmsg_pb_##i, \ + .rx_pb = &rx_icbmsg_pb_##i, \ + }}; \ + static MAYBE_CONST struct icbmsg_config backend_config_##i = { \ + .control_config = \ + { \ + .mbox_tx = MBOX_DT_SPEC_INST_GET(i, tx), \ + .mbox_rx = MBOX_DT_SPEC_INST_GET(i, rx), \ + .unbound_mode = ICMSG_UNBOUND_MODE_DISABLE, /* TODO: */ \ + }, \ + .tx =