Skip to content

Commit

Permalink
fix: remove default imageTag for messagequeue container (#114)
Browse files Browse the repository at this point in the history
* fix: remove default imageTag for messagequeue container

* update chart version

* add debug info

* update testing tools

* fix helm version

* update image version

* update image version

---------

Co-authored-by: Rares Matei <[email protected]>
  • Loading branch information
minijus and rarmatei committed Jul 17, 2024
1 parent 257db7a commit 1ab19eb
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 14 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/chart_lint_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
fetch-depth: 0

- name: Set up Helm
uses: azure/setup-helm@v3
uses: azure/setup-helm@v4.2.0
with:
version: v3.11.2
version: v3.15.3

- uses: actions/setup-python@v4
with:
Expand All @@ -38,8 +38,8 @@ jobs:

- name: Create kind cluster
if: steps.list-changed.outputs.changed == 'true'
uses: helm/kind-action@v1.4.0
uses: helm/kind-action@v1.10.0

- name: Run chart-testing (install)
if: steps.list-changed.outputs.changed == 'true'
run: ct install --config testing-files/ct.yaml --target-branch ${{ github.event.repository.default_branch }}
run: ct install --config testing-files/ct.yaml --target-branch ${{ github.event.repository.default_branch }} --debug
2 changes: 1 addition & 1 deletion charts/nx-cloud/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: nx-cloud
description: Nx Cloud Helm Chart
type: application
version: 0.15.5
version: 0.15.6
maintainers:
- name: nx
url: "https://nx.app/"
Expand Down
2 changes: 1 addition & 1 deletion charts/nx-cloud/ci/basic-values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global:
imageTag: '2308.22.7'
imageTag: '2405.02.15'

nxCloudAppURL: 'URL_TO_ACCESS_INGRESS_FROM_DEV_MACHINES'

Expand Down
2 changes: 1 addition & 1 deletion charts/nx-cloud/ci/endpointslice-values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global:
imageTag: '2308.22.7'
imageTag: '2405.02.15'

nxCloudAppURL: 'URL_TO_ACCESS_INGRESS_FROM_DEV_MACHINES'

Expand Down
2 changes: 1 addition & 1 deletion charts/nx-cloud/ci/scm-gh-values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global:
imageTag: '2308.22.7'
imageTag: '2405.02.15'

nxCloudAppURL: 'URL_TO_ACCESS_INGRESS_FROM_DEV_MACHINES'

Expand Down
2 changes: 1 addition & 1 deletion charts/nx-cloud/ci/scm-gl-values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global:
imageTag: '2308.22.7'
imageTag: '2405.02.15'

nxCloudAppURL: 'URL_TO_ACCESS_INGRESS_FROM_DEV_MACHINES'

Expand Down
2 changes: 1 addition & 1 deletion charts/nx-cloud/ci/sh-like-values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global:
imageTag: '2308.22.7'
imageTag: '2405.02.15'

verboseLogging: 'true'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global:
imageTag: '2308.22.7'
imageTag: '2405.02.15'

nxCloudAppURL: 'URL_TO_ACCESS_INGRESS_FROM_DEV_MACHINES'

Expand Down
2 changes: 1 addition & 1 deletion charts/nx-cloud/ci/wfcontroller-values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global:
imageTag: '2308.22.7'
imageTag: '2405.02.15'

nxCloudAppURL: 'URL_TO_ACCESS_INGRESS_FROM_DEV_MACHINES'

Expand Down
2 changes: 1 addition & 1 deletion charts/nx-cloud/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ messagequeue:
registry: ''
imageName: nx-cloud-messagequeue
repository: ''
tag: latest
tag: ''
digest: ''
pullPolicy: Always
deployment:
Expand Down
2 changes: 1 addition & 1 deletion testing-files/ct.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ remote: origin
target-branch: main
chart-dirs:
- charts
helm-extra-args: --timeout 600s
helm-extra-args: --timeout 300s

0 comments on commit 1ab19eb

Please sign in to comment.