Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor PDV to get data directly from nxls & apply in intellij #2254

Merged
merged 30 commits into from
Sep 19, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Sep 9, 2024

test scenarios:

  • change project.json and back
  • change plugin config file and back
  • change nx.json and back
  • change package.json and back
  • error the above and back
  • add plugin to nx.json
  • make plugin config changes in nx.json
  • source map tooltips are shown
  • interaction events work (even after a refresh)
  • no node_modules installed -> install
  • multiple projects for one file
  • expand target -> refresh -> stays open

setup scenarios:

  • newly created workspace
  • nx repo migrated
  • ocean repo migrated
  • dot nx installation
  • windows- [ ]

Copy link

nx-cloud bot commented Sep 13, 2024

apps/vscode/package.json Outdated Show resolved Hide resolved
@jaysoo
Copy link
Member

jaysoo commented Sep 17, 2024

Let's take the WIP vscode changes to another PR.

@MaxKless MaxKless marked this pull request as ready for review September 17, 2024 16:01
Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it is working. There seems to be a failing unit test that needs to be updated.

@MaxKless MaxKless merged commit bf2ad34 into master Sep 19, 2024
4 checks passed
@MaxKless MaxKless deleted the pdv-rework-test branch September 19, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants