Dev 29/upgrade go 1.23 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isolated nodes are processed as separate connected components and connected components with one node are short-circuited as of commit ccd6690
…pported since v0.7.0
This change reflects the actual usage of this struct field, i.e. the layers are iterated as an ordered sequence, mostly top-to-bottom. As a matter of fact, this allows to rewrite several for-loops in the form i:=0;i<len(g.Layers);i++ as simple ranges: the index form was used to enforce a deterministic order when iterating over map entries. Indexing the slice with g.Layers[node.Layer] doesn't change the program semantics from when it was a map, as the Layers slice is initialized in postprocessing of phase 2 based on the node.Layer indices.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.