Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): Setup provider using the provider key #1420

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tofandel
Copy link

@Tofandel Tofandel commented Aug 5, 2024

πŸ”— Linked issue

Fixes #1414

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Because the name is user provided and can (and should be different if we have multiple instances of one provider) then any name different than the provider name (eg: my-remote-ipx instead of ipx) will not setup the provider as expected

@Tofandel
Copy link
Author

Tofandel commented Aug 6, 2024

Drafting this for now as there is some weird things going on with ipx

if (typeof p.setup === "function" && p.name !== "ipx" && p.name !== "ipxStatic") {
        await p.setup(p, options, nuxt);
}

Because we can't use nitro so early

@Tofandel Tofandel marked this pull request as draft August 6, 2024 11:26
@danielroe
Copy link
Member

would you be able to add an example of the usage you have in mind, perhaps by adding it to the test fixture? πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPX provider not working properly when the default provider is not IPX
2 participants