-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default to decoding: async
#996
base: main
Are you sure you want to change the base?
Conversation
note that there is already a PR open for fetchpriority implementation: #989 |
Hi @danielroe, and I apologize for adding |
decoding: async
@sanjaiyan-dev @danielroe I wonder if an image that has the |
Hi @Tragio, Sorry for the late response. Actually, the I believe you may have confused it with the |
Thanks for this PR. Is there any benchmark reference btw that enabling async decoding enables overall performance? I like to see it because changing browser defaults should usually have strong reasons specially for a default. |
I'm extremely sorry, but currently, I don't have any benchmark results. However, this is set as the default in Next.js and Astro js. Here is an article about deciding asynchronously: link for the article. |
Thanks for the links. I think i remember the article by addy from past from few years ago and i guess we also made an experiment with @farnabaz that at least ~2 years ago it wasn't a positive improvement for images that are expected to be in the initial viewport with async decoding. I will check this with chrome team in this week. |
Yes, my question is if we are preloading an image is because we want to to render it as fast as possible, for example, to reduce LCP. So how would it be affected? If we are preloading and saying to the browser it is not very important to render? If I'm not mistaken, Firefox is the only one that defaults to async. Safari only sets to async in some specific scenarios. |
Hi @Tragio, The For more references, please visit: https://cloudinary.com/blog/guest_post/asynchronously-load-and-decode-images#html_code_lt_img_gt_code_decoding_attribute |
Hey everyone! Just checking in to see if this be implemented next release? I actually posted an issue about page rendering issues with Anyways, I hope this can be merged next release |
Hey @pi0, just checking on updates for this. Thanks!:) |
Hi, this PR aims to achieve a minor performance improvement by implementing the following changes:
decoding
attribute in the image tag asynchronous (similar to Next.js - https://nextjs.org/docs/app/api-reference/components/image#other-props):