Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InputNumber): implement component #2577

Open
wants to merge 31 commits into
base: v3
Choose a base branch
from
Open

Conversation

hywax
Copy link

@hywax hywax commented Nov 8, 2024

πŸ”— Linked issue

Resolves #2523

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add component from radix-vue https://www.radix-vue.com/components/number-field.html

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@hywax hywax changed the title feat(InputNumber): implement component feat(NumberField): implement component Nov 9, 2024
@benjamincanac
Copy link
Member

benjamincanac commented Nov 9, 2024

I think it makes sense to call it InputNumber actually!

  • InputXXX with either a menu or a type (file, number, etc.), we could have UInputFile, UInputDate, etc.
  • PinInput / TagsInput that kind of wrap an input

@hywax hywax changed the title feat(NumberField): implement component feat(InputNumber): implement component Nov 9, 2024
src/runtime/components/InputNumber.vue Outdated Show resolved Hide resolved
src/runtime/components/InputNumber.vue Outdated Show resolved Hide resolved
@benjamincanac benjamincanac added the v3 #1289 label Nov 11, 2024
@hywax
Copy link
Author

hywax commented Nov 11, 2024

@benjamincanac looks something like this

Copy link

pkg-pr-new bot commented Nov 11, 2024

pnpm add https://pkg.pr.new/@nuxt/ui@2577

commit: e524d0b

@hywax hywax marked this pull request as ready for review November 11, 2024 19:38
@hywax
Copy link
Author

hywax commented Nov 11, 2024

Almost done. There are only two things left to do:

  1. Writing the tests, the todo for them is already done.
  2. Maybe change the styles a bit, but I'm not sure.

@hywax
Copy link
Author

hywax commented Nov 12, 2024

@benjamincanac please help me. I made test blanks, everything should work, but a few tests (which .todo) are not working, I can't understand the reason why.

@hywax hywax mentioned this pull request Nov 12, 2024
8 tasks
@benjamincanac
Copy link
Member

@hywax I have a few PRs to take care first, I'll take a look asap!

@benjamincanac
Copy link
Member

@hywax I've made a few changes but haven't looked at the failing tests yet. I'm using buttons now which make it easier to style. Not sure about the scale in vertical orientation though. Let me know what you think!

@hywax
Copy link
Author

hywax commented Nov 12, 2024

@benjamincanac It looks amazing!

@benjamincanac
Copy link
Member

@romhml Would you have an idea regarding the failing tests?

@benjamincanac
Copy link
Member

@hywax @adamkasper @BlackWhite2000 @MuhammadM1998 Would you mind reviewing the updated locales in this PR?

@MuhammadM1998
Copy link
Contributor

The Arabic messages are correct @benjamincanac. Great job! @hywax

@hywax
Copy link
Author

hywax commented Nov 13, 2024

@benjamincanac thank you so much for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants