-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(InputNumber): implement component #2577
base: v3
Are you sure you want to change the base?
Conversation
I think it makes sense to call it
|
@benjamincanac looks something like this |
commit: |
Almost done. There are only two things left to do:
|
@benjamincanac please help me. I made test blanks, everything should work, but a few tests (which .todo) are not working, I can't understand the reason why. |
@hywax I have a few PRs to take care first, I'll take a look asap! |
@hywax I've made a few changes but haven't looked at the failing tests yet. I'm using buttons now which make it easier to style. Not sure about the |
@benjamincanac It looks amazing! |
@romhml Would you have an idea regarding the failing tests? |
@hywax @adamkasper @BlackWhite2000 @MuhammadM1998 Would you mind reviewing the updated locales in this PR? |
The Arabic messages are correct @benjamincanac. Great job! @hywax |
@benjamincanac thank you so much for this contribution! |
π Linked issue
Resolves #2523
β Type of change
π Description
Add component from radix-vue https://www.radix-vue.com/components/number-field.html
π Checklist